Bug 235539

Summary:

Web Inspector: Network: give the Ignore Caches button a label so it's more visible and immediately understandable

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[fast-cq] Patch	none
[Image] after Patch is applied	none
Patch	none
[fast-cq] Patch	none
[fast-cq] Patch	none

Description Devin Rousso 2022-01-24 13:44:58 PST

Comment 1 Devin Rousso 2022-01-24 13:48:32 PST

Created attachment 449853 [details]
[fast-cq] Patch

Comment 2 Patrick Angle 2022-01-24 14:01:40 PST

<rdar://87792377>

Comment 3 Joseph Pecoraro 2022-01-24 14:02:29 PST

Sounds like a good idea! Screenshot?

Comment 4 Devin Rousso 2022-01-24 14:32:49 PST

Created attachment 449858 [details]
[Image] after Patch is applied

Comment 5 Devin Rousso 2022-01-24 14:43:04 PST

Created attachment 449860 [details]
Patch

fix issue where the `WI.DividerNavigationItem` would get hidden before `this._disableResourceCacheNavigationItem`

Comment 6 Devin Rousso 2022-01-24 14:53:19 PST

Created attachment 449863 [details]
[fast-cq] Patch

rebase

Comment 7 Joseph Pecoraro 2022-01-24 15:16:43 PST

Comment on attachment 449863 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449863&action=review

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:-146
> -            this._disableResourceCacheNavigationItem = new WI.ActivateButtonNavigationItem("disable-resource-cache", toolTipForDisableResourceCache, activatedToolTipForDisableResourceCache, "Images/IgnoreCaches.svg", 16, 16);

Seems like we can delete `IgnoreCaches.svg` now?

Comment 8 Devin Rousso 2022-01-24 16:50:10 PST

Created attachment 449882 [details]
[fast-cq] Patch

Comment 9 Patrick Angle 2022-01-24 18:45:38 PST

Comment on attachment 449882 [details]
[fast-cq] Patch

r=me

I think you need to rebase again before landing, though. The review tool is complaining that it can't apply the patch any more.

Comment 10 EWS 2022-01-24 19:22:12 PST

Committed r288533 (246367@main): <https://commits.webkit.org/246367@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449882 [details].