Summary: | Web Inspector: Network: move filtering checkboxes into a single gear-with-contextmenu to save space | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=235541 https://bugs.webkit.org/show_bug.cgi?id=235546 |
||||||||
Attachments: |
|
Description
Devin Rousso
2022-01-24 13:44:05 PST
Created attachment 449852 [details]
[fast-cq] Patch
Comment on attachment 449852 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449852&action=review r=me > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:2281 > + contextMenu.appendCheckboxItem(WI.UIString("Preserve Log"), () => { An aside, but could certainly be dealt with in this same bug: `Preserve Log` to me doesn't clearly communicate what this setting does. When I think "log", I think about the Console Tab and `console.log` et al.. Something like "Clear requests on navigation" or "Clear request history on navigation" (subject to further bike shedding) would better communicate the option IMO now that these are in a dropdown menu and we have a bit more space. Comment on attachment 449852 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449852&action=review >> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:2281 >> + contextMenu.appendCheckboxItem(WI.UIString("Preserve Log"), () => { > > An aside, but could certainly be dealt with in this same bug: `Preserve Log` to me doesn't clearly communicate what this setting does. When I think "log", I think about the Console Tab and `console.log` et al.. Something like "Clear requests on navigation" or "Clear request history on navigation" (subject to further bike shedding) would better communicate the option IMO now that these are in a dropdown menu and we have a bit more space. Yeah that's a good point. We should change this to something clearer now that it's in a contextmenu (which gives us more space). Also, we should probably do something similar in the Console since there's a "Preserve Log" there too <https://webkit.org/b/235541> Created attachment 449857 [details]
[Image] after Patch is applied
Committed r288470 (246355@main): <https://commits.webkit.org/246355@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449852 [details]. |