Bug 235527

Summary: Missing EnabledBySetting=WebXREnabled where Conditional=WEBXR exists
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: WebXRAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, kondapallykalyan, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235531
Attachments:
Description Flags
Patch
none
Patch none

Sam Sneddon [:gsnedders]
Reported 2022-01-24 10:35:14 PST
There's a few places we're missing this, patch forthcoming. <rdar://87976757>
Attachments
Patch (2.84 KB, patch)
2022-01-24 10:45 PST, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2022-01-24 11:20 PST, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2022-01-24 10:45:27 PST
Created attachment 449829 [details] Patch
Darin Adler
Comment 2 2022-01-24 11:07:26 PST
Comment on attachment 449829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449829&action=review > Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl:31 > + EnabledBySetting=WebXREnabled, > Conditional=WEBXR Normally we like to keep these alphabetical.
Sam Sneddon [:gsnedders]
Comment 3 2022-01-24 11:20:34 PST
Created attachment 449832 [details] Patch
EWS
Comment 4 2022-01-25 08:49:06 PST
Committed r288553 (246385@main): <https://commits.webkit.org/246385@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449832 [details].
Note You need to log in before you can comment on or make changes to this bug.