Bug 235514

Summary:

[CSS Container Queries] Basic parsing support for container-type property

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Antti Koivisto <koivisto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jenner, joepeck, kondapallykalyan, macpherson, menard, pdr, ryanhaddad, sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

229659

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Antti Koivisto 2022-01-24 06:50:16 PST

https://drafts.csswg.org/css-contain-3/#container-type

Comment 1 Antti Koivisto 2022-01-24 07:17:30 PST

Created attachment 449810 [details]
Patch

Comment 2 Antti Koivisto 2022-01-24 08:13:26 PST

Created attachment 449819 [details]
Patch

Comment 3 Antti Koivisto 2022-01-24 12:44:30 PST

Created attachment 449847 [details]
Patch for landing

Comment 4 EWS 2022-01-24 14:03:46 PST

Committed r288465 (246351@main): <https://commits.webkit.org/246351@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449847 [details].

Comment 5 Radar WebKit Bug Importer 2022-01-24 14:04:21 PST

<rdar://problem/87989276>

Comment 6 Aakash Jain 2022-01-25 09:33:26 PST

(In reply to EWS from comment #4)
> Committed r288465 (246351@main): <https://commits.webkit.org/246351@main>

This broke two layout-tests on ios-wk2.

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcssom%2FgetComputedStyle-detached-subtree.html
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-contain%2Fcontainer-queries%2Fcontainer-type-containment.html

EWS also indicated that on previous patch on this bug in https://ews-build.webkit.org/#/builders/68/builds/6336, and many EWSes were red. Still, the newer patch was landed without even running through EWS.

Comment 7 Robert Jenner 2022-01-25 12:22:46 PST

Rebased tests for iOS here:

https://trac.webkit.org/changeset/288574/webkit