Bug 235513

Summary: Incorrect pull-request url printed by git-webkit
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235358
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2022-01-24 06:40:31 PST
After the fix in https://github.com/WebKit/WebKit/pull/80, git-webkit pr now prints the pr url, which is great. However, the url has a typo making it incorrect. e.g.: https://github.com/WebKit/WebKit/pulls/89 instead of https://github.com/WebKit/WebKit/pull/89 (pulls instead of pull). We should fix this.
Attachments
Proposed patch (2.54 KB, patch)
2022-01-24 11:47 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2022-01-24 11:47:44 PST
Created attachment 449838 [details] Proposed patch
Aakash Jain
Comment 2 2022-01-24 12:10:53 PST
Pull Request: https://github.com/WebKit/WebKit/pull/91
Aakash Jain
Comment 3 2022-01-25 05:44:43 PST
Landed https://commits.webkit.org/246353@main (d6f2ef7)!
Radar WebKit Bug Importer
Comment 4 2022-01-25 05:45:23 PST
<rdar://problem/88019800>
Note You need to log in before you can comment on or make changes to this bug.