Bug 235502

Summary: Add a WebShare policy quirk for Twitter
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, marcos, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=243088
Bug Depends on:    
Bug Blocks: 235590    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2022-01-24 01:03:52 PST
Add a WebShare policy quirk for Twitter
Attachments
Patch (5.00 KB, patch)
2022-01-24 02:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.25 KB, patch)
2022-01-24 03:39 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.96 KB, patch)
2022-01-25 05:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-01-24 01:04:33 PST
<rdar://87944391>
youenn fablet
Comment 2 2022-01-24 02:07:07 PST
Created attachment 449793 [details] Patch
youenn fablet
Comment 3 2022-01-24 03:39:42 PST
Created attachment 449797 [details] Patch
youenn fablet
Comment 4 2022-01-24 06:31:46 PST
Comment on attachment 449797 [details] Patch win failure unrelated
Chris Dumez
Comment 5 2022-01-24 11:38:30 PST
Comment on attachment 449797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449797&action=review r=me > Source/WebCore/page/Quirks.cpp:89 > + return topPrivatelyControlledDomain(document.url().host().toString()) == "twitter.com"; Why not use RegistrableDomain instead of calling topPrivatelyControlledDomain() and having to deal with #ifdefs?
youenn fablet
Comment 6 2022-01-24 11:54:04 PST
(In reply to Chris Dumez from comment #5) > Comment on attachment 449797 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449797&action=review > > r=me > > > Source/WebCore/page/Quirks.cpp:89 > > + return topPrivatelyControlledDomain(document.url().host().toString()) == "twitter.com"; > > Why not use RegistrableDomain instead of calling > topPrivatelyControlledDomain() and having to deal with #ifdefs? RegistrableDomain constructor is doing a little bit more work. The point on #ifdef is good though.
youenn fablet
Comment 7 2022-01-25 05:24:57 PST
Created attachment 449920 [details] Patch for landing
EWS
Comment 8 2022-01-25 06:10:14 PST
Committed r288546 (246378@main): <https://commits.webkit.org/246378@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449920 [details].
Note You need to log in before you can comment on or make changes to this bug.