Bug 235499

Summary:

AX: When disabledAttr changes, we don't need to post a notification, only update the isolated tree

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

NEW ---

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+, ews-feeder: commit-queue-

Description Tyler Wilcock 2022-01-23 16:19:33 PST

In https://bugs.webkit.org/show_bug.cgi?id=235246, we added:

else if (attrName == disabledAttr)
    postNotification(element, AXObjectCache::AXDisabledStateChanged);

So that we could update the isolated tree when this happens. However, posting a notification here is unnecessary work, since we can just call updateIsolatedTree directly instead.

Comment 1 Radar WebKit Bug Importer 2022-01-23 16:19:51 PST

<rdar://problem/87947110>

Comment 2 Tyler Wilcock 2022-01-23 16:23:09 PST

Created attachment 449770 [details]
Patch

Comment 3 Darin Adler 2022-01-23 16:50:08 PST

Comment on attachment 449770 [details]
Patch

I’ll take your word that this was not required. Is there some discipline where we can verify such things with tests, not just with knowledge of the code?

Comment 4 Andres Gonzalez 2022-01-24 08:09:17 PST

I'm not certain that a notification is not required. Clients may need to know that something is now disabled or not. Even if some clients are not using it at the moment, we should post the notification for API consistency.