Bug 235486

Summary:

[GTK][a11y] Test accessibility/url-test.html fails with ATSPI

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, darin

Priority:

Keywords:

Gtk, LayoutTestFailure

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

230253

Attachments:

Description	Flags
Patch	darin: review+, ews-feeder: commit-queue-

Description Carlos Garcia Campos 2022-01-23 00:21:35 PST

PASS element.url.indexOf('url-test1.html') != -1 is true
-PASS element.url.indexOf('url-test2.html') != -1 is true
+FAIL element.url.indexOf('url-test2.html') != -1 should be true. Was false.
 PASS element.url.indexOf('url-test3.png') != -1 is true
 PASS successfullyParsed is true

url-test2.html is actually the fragment id, and we are getting just the path when removing the base path.

Comment 1 Carlos Garcia Campos 2022-01-23 00:23:28 PST

Created attachment 449746 [details]
Patch

Comment 2 Darin Adler 2022-01-23 10:58:30 PST

Comment on attachment 449746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449746&action=review

> Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1387
> +        auto index = stringURL.find("LayoutTests");

Not great that we have to hardcode the directory name here. I don’t think we do that other places in the test runners.

Comment 3 Carlos Garcia Campos 2022-01-24 08:18:49 PST

Committed r288444 (246333@trunk): <https://commits.webkit.org/246333@trunk>