Bug 235481

Summary: AX: Remove duplication in AXObjectCache::updateIsolatedTree implementations
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2022-01-22 09:01:28 PST
The singular-object versions (AXObjectCache::updateIsolatedTree(AXCoreObject&, AXNotification)) and multiple-object version (AXObjectCache::updateIsolatedTree(const Vector<std::pair<RefPtr<AXCoreObject>, AXNotification>>&)) duplicate a lot of code, and make it possible to forget to add new notification handling in one place or the other.
Attachments
Patch (5.32 KB, patch)
2022-01-22 09:08 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-22 09:01:37 PST
<rdar://problem/87926354>
Tyler Wilcock
Comment 2 2022-01-22 09:08:11 PST
Created attachment 449733 [details] Patch
EWS
Comment 3 2022-01-23 08:51:30 PST
Committed r288419 (246310@main): <https://commits.webkit.org/246310@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449733 [details].
Note You need to log in before you can comment on or make changes to this bug.