Bug 235481

Summary:

AX: Remove duplication in AXObjectCache::updateIsolatedTree implementations

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Tyler Wilcock 2022-01-22 09:01:28 PST

The singular-object versions (AXObjectCache::updateIsolatedTree(AXCoreObject&, AXNotification)) and multiple-object version (AXObjectCache::updateIsolatedTree(const Vector<std::pair<RefPtr<AXCoreObject>, AXNotification>>&)) duplicate a lot of code, and make it possible to forget to add new notification handling in one place or the other.

Comment 1 Radar WebKit Bug Importer 2022-01-22 09:01:37 PST

<rdar://problem/87926354>

Comment 2 Tyler Wilcock 2022-01-22 09:08:11 PST

Created attachment 449733 [details]
Patch

Comment 3 EWS 2022-01-23 08:51:30 PST

Committed r288419 (246310@main): <https://commits.webkit.org/246310@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449733 [details].