Summary: | WebKit fails to build - error: 'webrtc/rtc_base/network.h' file not found | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, mark.lam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2022-01-21 15:32:59 PST
Created attachment 449705 [details]
Patch
Comment on attachment 449705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449705&action=review I'm not super familiar with the plumbing of all the settings variables, but this patch LGTM. > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:27 > + RELATIVE_PATH_FROM_SYMLINK_TO_ROOT=$(echo "${PUBLIC_FOLDER_PREFIX}" | sed -E -e "s/\/[a-zA-Z0-9_]+/..\//g" -e "s/\/$//") Why is this "s/\/$//" needed? > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:28 > + SYMLINK_VALUE="${RELATIVE_PATH_FROM_SYMLINK_TO_ROOT}${INSTALL_FOLDER_PREFIX}/${TARGET}" nit: call this SYMLINK_TARGET instead? > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:52 > + if [[ ! -d ${SYSTEM_PUBLIC_HEADER_PREFIX} ]]; then > + mkdir -p ${SYSTEM_PUBLIC_HEADER_PREFIX} > + fi Can't you do this just once outside of the for loop? The only difference is that moving this out would create this directory even if HEADER_FOLDER_LIST is empty. But we know it'll never be empty, right? > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:64 > + if [[ ! -d ${SYSTEM_PUBLIC_LIBRARY_PREFIX} ]]; then > + mkdir -p ${SYSTEM_PUBLIC_LIBRARY_PREFIX} > + fi Ditto. Do this outside the for loop? (In reply to Mark Lam from comment #3) > Comment on attachment 449705 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449705&action=review > > I'm not super familiar with the plumbing of all the settings variables, but > this patch LGTM. > > > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:27 > > + RELATIVE_PATH_FROM_SYMLINK_TO_ROOT=$(echo "${PUBLIC_FOLDER_PREFIX}" | sed -E -e "s/\/[a-zA-Z0-9_]+/..\//g" -e "s/\/$//") > > Why is this "s/\/$//" needed? To eliminate any trailing '/'. > > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:28 > > + SYMLINK_VALUE="${RELATIVE_PATH_FROM_SYMLINK_TO_ROOT}${INSTALL_FOLDER_PREFIX}/${TARGET}" > > nit: call this SYMLINK_TARGET instead? This follows some the name of other similar scripts. > > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:52 > > + if [[ ! -d ${SYSTEM_PUBLIC_HEADER_PREFIX} ]]; then > > + mkdir -p ${SYSTEM_PUBLIC_HEADER_PREFIX} > > + fi > > Can't you do this just once outside of the for loop? The only difference is > that moving this out would create this directory even if HEADER_FOLDER_LIST > is empty. But we know it'll never be empty, right? > > > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:64 > > + if [[ ! -d ${SYSTEM_PUBLIC_LIBRARY_PREFIX} ]]; then > > + mkdir -p ${SYSTEM_PUBLIC_LIBRARY_PREFIX} > > + fi > > Ditto. Do this outside the for loop? I moved both of these to above the loop. Committed r288391 (246288@trunk): <https://commits.webkit.org/246288@trunk> |