Summary: | [libpas] Ensure pas_allocation_callback and pas_deallocation_callback are initialized as NULL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fpizlo, mark.lam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2022-01-20 16:07:01 PST
Created attachment 449618 [details]
Patch
Created attachment 449619 [details]
Patch
Comment on attachment 449619 [details]
Patch
r=me
Committed r288339 (246245@main): <https://commits.webkit.org/246245@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449619 [details]. Comment on attachment 449619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449619&action=review > Source/bmalloc/libpas/src/libpas/pas_allocation_callbacks.c:33 > +pas_allocation_callback_t pas_allocation_callback = NULL; > +pas_deallocation_callback_t pas_deallocation_callback = NULL; The "_t" suffix isn't used by any types in libpas other than this. I think that the way that I would normally do this is call the type "pas_allocation_callback" and call the variable "pas_allocation_callback_instance". Saying "pas_allocation_callback_type" could be cool too. Committed r288381 (246278@trunk): <https://commits.webkit.org/246278@trunk> (In reply to Filip Pizlo from comment #6) > Comment on attachment 449619 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449619&action=review > > > Source/bmalloc/libpas/src/libpas/pas_allocation_callbacks.c:33 > > +pas_allocation_callback_t pas_allocation_callback = NULL; > > +pas_deallocation_callback_t pas_deallocation_callback = NULL; > > The "_t" suffix isn't used by any types in libpas other than this. I think > that the way that I would normally do this is call the type > "pas_allocation_callback" and call the variable > "pas_allocation_callback_instance". Saying "pas_allocation_callback_type" > could be cool too. Changed the typenames. |