Bug 235413 – [fast-cq] [macOS] Various tests hit debug assertions under `SearchBuffer::search` after system ICU changes

• Component: HTML Editing
• Status: RESOLVED FIXED

[Wenson Hsieh]

rdar://87423185

[Wenson Hsieh]

Created attachment 449598 [details]
Patch

[Darin Adler]

Comment on attachment 449598 [details]
Patch

I think it’s likely we have other places where we are checking against U_ZERO_ERROR where we really mean U_SUCCESS.

[Wenson Hsieh]

Thanks for the review!

(In reply to Darin Adler from comment #2)
> Comment on attachment 449598 [details]
> Patch
> 
> I think it’s likely we have other places where we are checking against
> U_ZERO_ERROR where we really mean U_SUCCESS.

Yes — it's certainly possible. I locally only ran a subset of layout tests that use text iterators (`accessibility`, `fast`, and `editing`), and didn't see any other ICU-related crashes/assertions, but did not run the full suite.

I think I'll land this change sooner to stop Mac layout tests from exiting early, and then see if there are any more places where we need similar treatment w.r.t. status codes from ICU.

[Darin Adler]

(In reply to Wenson Hsieh from comment #3)
> I think I'll land this change sooner to stop Mac layout tests from exiting
> early, and then see if there are any more places where we need similar
> treatment w.r.t. status codes from ICU.

Yes, I was talking about future proofing. Completely agree about landing just this. Also, since this change is inside an assertion only, we can rest easy that it only affects debug builds.

[EWS]

Found 1 new test failure: imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html

[EWS]

Committed r288327 (246239@main): <https://commits.webkit.org/246239@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449598 [details].