Bug 235403

Summary:

[LFC][IFC] LineBuilder::layoutInlineContent should take PreviousLine

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2022-01-20 08:19:42 PST

we need to know about the previous line's state

Comment 1 zalan 2022-01-20 08:24:24 PST

Created attachment 449576 [details]
Patch

Comment 2 Antti Koivisto 2022-01-20 08:38:17 PST

Comment on attachment 449576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449576&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:308
> +LineBuilder::LineContent LineBuilder::layoutInlineContent(const InlineItemRange& needsLayoutRange, const InlineRect& lineLogicalRect, std::optional<PreviousLine> previousLine)

maybe the previousLine could be a const&? It is smallish but not tiny.

Comment 3 zalan 2022-01-20 11:17:13 PST

Created attachment 449596 [details]
Patch

Comment 4 EWS 2022-01-20 13:19:30 PST

Committed r288317 (246233@main): <https://commits.webkit.org/246233@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449596 [details].

Comment 5 Radar WebKit Bug Importer 2022-01-20 13:20:20 PST

<rdar://problem/87846330>