Bug 235392

Summary: [LFC][IFC] Implement TextUtil::directionForTextContent
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2022-01-19 20:20:13 PST
ssia
Attachments
Patch (2.02 KB, patch)
2022-01-19 20:24 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2022-01-20 08:52 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-01-19 20:24:37 PST
Created attachment 449549 [details] Patch
zalan
Comment 2 2022-01-20 08:52:54 PST
Created attachment 449585 [details] Patch
Antti Koivisto
Comment 3 2022-01-20 08:58:09 PST
Comment on attachment 449585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449585&action=review > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:345 > +TextDirection TextUtil::directionForTextContent(StringView content) > { > - ASSERT_NOT_IMPLEMENTED_YET(); > - return TextDirection::LTR; > + if (content.is8Bit()) > + return TextDirection::LTR; > + return ubidi_getBaseDirection(content.characters16(), content.length()) == UBIDI_RTL ? TextDirection::RTL : TextDirection::LTR; > } Nice
EWS
Comment 4 2022-01-20 18:59:23 PST
Committed r288343 (246249@main): <https://commits.webkit.org/246249@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449585 [details].
Radar WebKit Bug Importer
Comment 5 2022-01-20 19:00:17 PST
<rdar://problem/87862754>
Note You need to log in before you can comment on or make changes to this bug.