Bug 235352

Summary:

TestRunner.setMockCameraOrientation cannot set 270

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

Media

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

NEW ---

Severity:

Normal

CC:

ap, jbedard, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

235233

Bug Blocks:

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-

Description Kimmo Kinnunen 2022-01-19 02:51:59 PST

TestRunner.setMockCameraOrientation cannot set 270

it should be settable via -90 but the C++ part is unsigned

Comment 1 Kimmo Kinnunen 2022-01-20 11:19:14 PST

Created attachment 449597 [details]
Patch

Comment 2 youenn fablet 2022-01-21 03:08:00 PST

Comment on attachment 449597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449597&action=review

> Source/WebKit/ChangeLog:12
> +        For untrusted IPC APIs, add a if check.

It seems passing an enum like MediaSample::VideoRotation (maybe we should promote this enum to a standalone one) would help.

Comment 3 Radar WebKit Bug Importer 2022-01-26 02:52:28 PST

<rdar://problem/88067253>