Bug 235349

Summary: [libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E)
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, keith_miller, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2022-01-18 23:28:03 PST
[libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E)
Attachments
Patch (3.84 KB, patch)
2022-01-18 23:28 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.84 KB, patch)
2022-01-18 23:30 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2022-01-19 12:03 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-01-18 23:28:58 PST
Created attachment 449466 [details] Patch
Yusuke Suzuki
Comment 2 2022-01-18 23:30:24 PST
Created attachment 449467 [details] Patch
Darin Adler
Comment 3 2022-01-19 08:54:00 PST
Comment on attachment 449467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449467&action=review > Source/bmalloc/libpas/src/libpas/pas_platform.h:35 > +/* PAS_COMPILER() - the target copmiler */ Misspelled compiler here.
Saam Barati
Comment 4 2022-01-19 11:56:54 PST
Comment on attachment 449467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449467&action=review > Source/bmalloc/libpas/src/libpas/pas_config.h:45 > +#if PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E > +#define PAS_ENABLE_ASSERT 0 > +#else > +#define PAS_ENABLE_ASSERT 1 > +#endif Do we always enable this on debug builds?
Yusuke Suzuki
Comment 5 2022-01-19 12:01:25 PST
Comment on attachment 449467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449467&action=review >> Source/bmalloc/libpas/src/libpas/pas_config.h:45 >> +#endif > > Do we always enable this on debug builds? Done. >> Source/bmalloc/libpas/src/libpas/pas_platform.h:35 >> +/* PAS_COMPILER() - the target copmiler */ > > Misspelled compiler here. Fixed.
Yusuke Suzuki
Comment 6 2022-01-19 12:03:20 PST
Created attachment 449503 [details] Patch
Saam Barati
Comment 7 2022-01-19 12:05:05 PST
Comment on attachment 449503 [details] Patch r=me
Keith Miller
Comment 8 2022-01-19 12:05:11 PST
Comment on attachment 449503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449503&action=review > Source/bmalloc/libpas/src/libpas/pas_utils.h:203 > + if (!PAS_ENABLE_ASSERT) \ Not that it probably matters but you could do `if constexpr` here so Debug is faster too.
Yusuke Suzuki
Comment 9 2022-01-19 12:05:46 PST
Comment on attachment 449503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449503&action=review >> Source/bmalloc/libpas/src/libpas/pas_utils.h:203 >> + if (!PAS_ENABLE_ASSERT) \ > > Not that it probably matters but you could do `if constexpr` here so Debug is faster too. We cannot use it since this is C code (libpas is C, not C++). :)
EWS
Comment 10 2022-01-19 18:41:47 PST
Committed r288265 (246207@main): <https://commits.webkit.org/246207@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449503 [details].
Radar WebKit Bug Importer
Comment 11 2022-01-20 12:05:26 PST
<rdar://problem/87842725>
Note You need to log in before you can comment on or make changes to this bug.