Summary: | [libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, keith_miller, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2022-01-18 23:28:03 PST
Created attachment 449466 [details]
Patch
Created attachment 449467 [details]
Patch
Comment on attachment 449467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449467&action=review > Source/bmalloc/libpas/src/libpas/pas_platform.h:35 > +/* PAS_COMPILER() - the target copmiler */ Misspelled compiler here. Comment on attachment 449467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449467&action=review > Source/bmalloc/libpas/src/libpas/pas_config.h:45 > +#if PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E > +#define PAS_ENABLE_ASSERT 0 > +#else > +#define PAS_ENABLE_ASSERT 1 > +#endif Do we always enable this on debug builds? Comment on attachment 449467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449467&action=review >> Source/bmalloc/libpas/src/libpas/pas_config.h:45 >> +#endif > > Do we always enable this on debug builds? Done. >> Source/bmalloc/libpas/src/libpas/pas_platform.h:35 >> +/* PAS_COMPILER() - the target copmiler */ > > Misspelled compiler here. Fixed. Created attachment 449503 [details]
Patch
Comment on attachment 449503 [details]
Patch
r=me
Comment on attachment 449503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449503&action=review > Source/bmalloc/libpas/src/libpas/pas_utils.h:203 > + if (!PAS_ENABLE_ASSERT) \ Not that it probably matters but you could do `if constexpr` here so Debug is faster too. Comment on attachment 449503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449503&action=review >> Source/bmalloc/libpas/src/libpas/pas_utils.h:203 >> + if (!PAS_ENABLE_ASSERT) \ > > Not that it probably matters but you could do `if constexpr` here so Debug is faster too. We cannot use it since this is C code (libpas is C, not C++). :) Committed r288265 (246207@main): <https://commits.webkit.org/246207@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449503 [details]. |