Bug 235346

Summary: ColorTypes are no longer constexpr in debug builds due to std::isnan() in range assertions
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Sam Weinig
Reported 2022-01-18 19:44:56 PST
ColorTypes are no longer constexpr in debug builds due to std::isnan() in range assertions
Attachments
Patch (2.74 KB, patch)
2022-01-18 19:47 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2022-01-18 19:47:19 PST
Created attachment 449456 [details] Patch
Tim Horton
Comment 2 2022-01-18 20:26:37 PST
Comment on attachment 449456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449456&action=review > Source/WebCore/platform/graphics/ColorTypes.h:138 > + // FIXME: Replace std::isnan() once std::isnan() is constexpr. missing a `with`, I think.
EWS
Comment 3 2022-01-18 21:16:34 PST
Committed r288181 (246162@main): <https://commits.webkit.org/246162@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449456 [details].
Radar WebKit Bug Importer
Comment 4 2022-01-18 21:17:20 PST
<rdar://problem/87751737>
Sam Weinig
Comment 5 2022-01-19 09:26:35 PST
(In reply to Tim Horton from comment #2) > Comment on attachment 449456 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449456&action=review > > > Source/WebCore/platform/graphics/ColorTypes.h:138 > > + // FIXME: Replace std::isnan() once std::isnan() is constexpr. > > missing a `with`, I think. Indeed.
Note You need to log in before you can comment on or make changes to this bug.