Bug 235346

Summary: ColorTypes are no longer constexpr in debug builds due to std::isnan() in range assertions
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Description Sam Weinig 2022-01-18 19:44:56 PST 
ColorTypes are no longer constexpr in debug builds due to std::isnan() in range assertions
Comment 1 Sam Weinig 2022-01-18 19:47:19 PST 
Created attachment 449456 [details]
Patch
Comment 2 Tim Horton 2022-01-18 20:26:37 PST 
Comment on attachment 449456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449456&action=review

> Source/WebCore/platform/graphics/ColorTypes.h:138
> +    // FIXME: Replace std::isnan() once std::isnan() is constexpr.

missing a `with`, I think.
Comment 3 EWS 2022-01-18 21:16:34 PST 
Committed r288181 (246162@main): <https://commits.webkit.org/246162@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449456 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-18 21:17:20 PST 
<rdar://problem/87751737>
Comment 5 Sam Weinig 2022-01-19 09:26:35 PST 
(In reply to Tim Horton from comment #2)
> Comment on attachment 449456 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449456&action=review
> 
> > Source/WebCore/platform/graphics/ColorTypes.h:138
> > +    // FIXME: Replace std::isnan() once std::isnan() is constexpr.
> 
> missing a `with`, I think.

Indeed.