| Summary: | [JSC] Support import assertion syntax | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2022-01-18 01:04:31 PST
Created attachment 449367 [details]
Patch
Comment on attachment 449367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449367&action=review Code looks good overall, so r=me once EWS is all green. > Source/JavaScriptCore/runtime/ScriptFetchParameters.h:32 > +enum class ImportDataType : uint8_t { Are the changes to this file actually being used in this patch? If not, should they be postponed 'til the next one? Comment on attachment 449367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449367&action=review Code looks good overall, so r=me once EWS is all green. > Source/JavaScriptCore/runtime/ScriptFetchParameters.h:32 > +enum class ImportDataType : uint8_t { Are the changes to this file actually being used in this patch? If not, should they be postponed 'til the next one? Created attachment 449552 [details]
Patch
Created attachment 449556 [details]
Patch
Committed r288473 (246356@main): <https://commits.webkit.org/246356@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449556 [details]. |