Bug 235312

Summary: [JSC] Support import assertion syntax
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ross.kirsling: review+, ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Yusuke Suzuki
Reported 2022-01-18 01:04:31 PST
[JSC] Support import assertion syntax
Attachments
Patch (34.17 KB, patch)
2022-01-18 01:05 PST, Yusuke Suzuki 		ross.kirsling: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (59.37 KB, patch)
2022-01-19 21:49 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (65.17 KB, patch)
2022-01-19 23:46 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-01-18 01:05:52 PST
Created attachment 449367 [details] Patch
Ross Kirsling
Comment 2 2022-01-18 09:45:07 PST Comment hidden (obsolete)
Ross Kirsling
Comment 3 2022-01-18 09:45:08 PST
Comment on attachment 449367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449367&action=review Code looks good overall, so r=me once EWS is all green. > Source/JavaScriptCore/runtime/ScriptFetchParameters.h:32 > +enum class ImportDataType : uint8_t { Are the changes to this file actually being used in this patch? If not, should they be postponed 'til the next one?
Yusuke Suzuki
Comment 4 2022-01-19 21:49:07 PST
Created attachment 449552 [details] Patch
Yusuke Suzuki
Comment 5 2022-01-19 23:46:47 PST
Created attachment 449556 [details] Patch
EWS
Comment 6 2022-01-24 14:52:28 PST
Committed r288473 (246356@main): <https://commits.webkit.org/246356@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449556 [details].
Radar WebKit Bug Importer
Comment 7 2022-01-24 14:53:17 PST
<rdar://problem/87991797>
Note You need to log in before you can comment on or make changes to this bug.