Bug 235280

Summary:

[libpas] medium directory lookup should bail if begin_index is zero to catch races with expendable memory decommit (cherry pick 434465bfb8e0c285d6763cf6aa0e04982199f824)

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

bmalloc

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ysuzuki: review+, ews-feeder: commit-queue-
better patch	ysuzuki: review+

Description Filip Pizlo 2022-01-16 11:58:24 PST

...

Comment 1 Filip Pizlo 2022-01-16 11:58:41 PST

<rdar://87249133>

Comment 2 Filip Pizlo 2022-01-16 12:06:45 PST

Created attachment 449285 [details]
the patch

Comment 3 Yusuke Suzuki 2022-01-18 01:06:37 PST

Comment on attachment 449285 [details]
the patch

r=me

Comment 4 Filip Pizlo 2022-01-18 20:28:15 PST

Created attachment 449461 [details]
better patch

When I tested the previous patch against the tests in the updated libpas (bug 235347), I found a bunch of issues. This fixes all of them, I think?

Comment 5 Yusuke Suzuki 2022-01-20 17:02:39 PST

Comment on attachment 449461 [details]
better patch

r=me

Comment 6 Filip Pizlo 2022-01-20 18:44:09 PST

Landed in https://trac.webkit.org/changeset/288342/webkit