Bug 235268

Summary:

Only use `diff --binary` switch on Windows

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bburg, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

27323

Bug Blocks:

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2022-01-15 11:38:02 PST

Only use `diff --binary` switch on Windows.

It was originally added for Windows ports that were not using Cygwin:

Bug 27323: Further improve non-Cygwin SVN support.
<https://bugs.webkit.org/show_bug.cgi?id=27323>
<https://commits.webkit.org/r46095>

Comment 1 David Kilzer (:ddkilzer) 2022-01-15 11:38:15 PST

<rdar://problem/87490487>

Comment 2 David Kilzer (:ddkilzer) 2022-01-15 11:40:15 PST

Created attachment 449260 [details]
Patch v1

Comment 3 Alexey Proskuryakov 2022-01-15 11:46:16 PST

Comment on attachment 449260 [details]
Patch v1

Do "-u -a" mean the same thing as expected in the scenario that you are addressing?

Comment 4 David Kilzer (:ddkilzer) 2022-01-15 14:46:21 PST

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 449260 [details]
> Patch v1
> 
> Do "-u -a" mean the same thing as expected in the scenario that you are
> addressing?

Yes.

Comment 5 EWS 2022-01-15 15:11:31 PST

Committed r288068 (246088@main): <https://commits.webkit.org/246088@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449260 [details].