Summary: | When a “autofilled and obscured” field becomes empty, turn “autofilled and obscured” off | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ellie Epskamp-Hunt <eepskamphunt> | ||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, mifenton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ellie Epskamp-Hunt
2022-01-14 15:03:44 PST
Created attachment 454872 [details]
Patch
Comment on attachment 454872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454872&action=review r=me > Source/WebCore/html/HTMLInputElement.cpp:1148 > if (m_isAutoFilledAndViewable && value.isEmpty()) > setAutoFilledAndViewable(false); Did you mean to delete this now that it's also done below? > LayoutTests/fast/forms/input-autofilled-and-obscured.html:34 > + document.execCommand("Delete"); Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`? (In reply to Devin Rousso from comment #3) > Comment on attachment 454872 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454872&action=review > > r=me > > > Source/WebCore/html/HTMLInputElement.cpp:1148 > > if (m_isAutoFilledAndViewable && value.isEmpty()) > > setAutoFilledAndViewable(false); > > Did you mean to delete this now that it's also done below? I sure did. > > > LayoutTests/fast/forms/input-autofilled-and-obscured.html:34 > > + document.execCommand("Delete"); > > Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`? Sure, I can verify that the text field is actually empty at this point. Created attachment 454889 [details]
Patch
Created attachment 454909 [details]
Patch
Committed r291426 (248552@main): <https://commits.webkit.org/248552@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454909 [details]. |