Bug 235256 – When a “autofilled and obscured” field becomes empty, turn “autofilled and obscured” off

• Component: Forms
• Status: RESOLVED FIXED

[Ellie Epskamp-Hunt]

When a “autofilled and obscured” field becomes empty, turn “autofilled and obscured” off

[Ellie Epskamp-Hunt]

<rdar://86244109>

[Ellie Epskamp-Hunt]

Created attachment 454872 [details]
Patch

[Devin Rousso]

Comment on attachment 454872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454872&action=review

r=me

> Source/WebCore/html/HTMLInputElement.cpp:1148
>      if (m_isAutoFilledAndViewable && value.isEmpty())
>          setAutoFilledAndViewable(false);

Did you mean to delete this now that it's also done below?

> LayoutTests/fast/forms/input-autofilled-and-obscured.html:34
> +        document.execCommand("Delete");

Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`?

[Ellie Epskamp-Hunt]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 454872 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454872&action=review
> 
> r=me
> 
> > Source/WebCore/html/HTMLInputElement.cpp:1148
> >      if (m_isAutoFilledAndViewable && value.isEmpty())
> >          setAutoFilledAndViewable(false);
> 
> Did you mean to delete this now that it's also done below?

I sure did.

> 
> > LayoutTests/fast/forms/input-autofilled-and-obscured.html:34
> > +        document.execCommand("Delete");
> 
> Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`?

Sure, I can verify that the text field is actually empty at this point.

[Ellie Epskamp-Hunt]

Created attachment 454889 [details]
Patch

[Ellie Epskamp-Hunt]

Created attachment 454909 [details]
Patch

[EWS]

Committed r291426 (248552@main): <https://commits.webkit.org/248552@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454909 [details].