| Summary: | [JSC] Fix Linux 64bit compilation | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail R. Gadelha <mikhail> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Mikhail R. Gadelha
2022-01-14 07:40:10 PST
Created attachment 449172 [details]
Patch
Comment on attachment 449172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449172&action=review > Source/WTF/wtf/PlatformUse.h:358 > +#if PLATFORM(MAC) I think this should be `OS(DARWIN)` since `PLATFORM(MAC)` is just macOS and not iOS/tvOS/watchOS, IIRC. Created attachment 449176 [details]
Patch
Comment on attachment 449176 [details]
Patch
This is not correct since PAS_USE_SPINLOCKS should be 1.
Created attachment 449204 [details]
Patch
Comment on attachment 449204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449204&action=review > Source/bmalloc/ChangeLog:11 > + r287941 enabled jit-heap for all platforms and for some reason the > + preprocessor was not identifying PAS_USE_SPINLOCKS as defined. This > + patch adds a #if defined(PAS_USE_SPINLOCKS) guard which fixes the > + issue. We should investigate why it is. > Source/bmalloc/libpas/src/libpas/pas_config.h:100 > +#if defined(PAS_BMALLOC) > #define PAS_USE_SPINLOCKS 1 > #else > #define PAS_USE_SPINLOCKS 0 Regardless of the condition, PAS_USE_SPINLOCKS is defined. So the following change is incorrect. > Source/bmalloc/libpas/src/libpas/pas_lock.h:54 > +#if defined(PAS_USE_SPINLOCKS) This is not correct since PAS_USE_SPINLOCKS is always defined. I'll take it since it is mix of jitheap and https://trac.webkit.org/changeset/287968/webkit. Created attachment 449215 [details]
Patch
Created attachment 449218 [details]
Patch
Created attachment 449220 [details]
Patch
Created attachment 449223 [details]
Patch
Created attachment 449224 [details]
Patch
Comment on attachment 449224 [details]
Patch
r=me too if EWS is happy.
Committed r288050 (246070@main): <https://commits.webkit.org/246070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449224 [details]. |