| Summary: | Remove ImplementationLacksVTable IDL attribute | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alecflett, beidson, benjamin, calvaris, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hi, hta, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pangle, pdr, philipj, sabouhallawa, schenney, sergio, tommyw, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2022-01-12 17:41:43 PST
Created attachment 449016 [details]
Patch
Comment on attachment 449016 [details]
Patch
r=me This is awesome!
Wow, don’t want to have to wait for Alex to land this, so tempted to just set commit-queue+ on it! This will need coordination with the internal builds to land. I think I'll leave it as an allowed attribute, then land that, then remove the internal ignored ImplementationLacksVTable attributes, then remove ImplementationLacksVTable from the list of allowed attributes. Created attachment 449397 [details]
Patch
Committed r288118 (246132@main): <https://commits.webkit.org/246132@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449397 [details]. Internal commit 0f5ee832212f7d5b552bb117c1428dc65c563f7e Reopening to attach new patch. Created attachment 449403 [details]
Patch
Committed r288133 (246140@main): <https://commits.webkit.org/246140@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449403 [details]. |