Bug 235170

Summary: Remove ImplementationLacksVTable IDL attribute
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, benjamin, calvaris, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hi, hta, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pangle, pdr, philipj, sabouhallawa, schenney, sergio, tommyw, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2022-01-12 17:41:43 PST
Remove ImplementationLacksVTable IDL attribute
Attachments
Patch (297.24 KB, patch)
2022-01-12 17:43 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (277.94 KB, patch)
2022-01-18 09:29 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (37.88 KB, patch)
2022-01-18 10:46 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-01-12 17:43:33 PST
Created attachment 449016 [details] Patch
Yusuke Suzuki
Comment 2 2022-01-12 18:39:55 PST
Comment on attachment 449016 [details] Patch r=me This is awesome!
Darin Adler
Comment 3 2022-01-16 11:07:54 PST
Wow, don’t want to have to wait for Alex to land this, so tempted to just set commit-queue+ on it!
Alex Christensen
Comment 4 2022-01-18 09:08:45 PST
This will need coordination with the internal builds to land. I think I'll leave it as an allowed attribute, then land that, then remove the internal ignored ImplementationLacksVTable attributes, then remove ImplementationLacksVTable from the list of allowed attributes.
Alex Christensen
Comment 5 2022-01-18 09:29:54 PST
Created attachment 449397 [details] Patch
EWS
Comment 6 2022-01-18 10:10:35 PST
Committed r288118 (246132@main): <https://commits.webkit.org/246132@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449397 [details].
Radar WebKit Bug Importer
Comment 7 2022-01-18 10:11:22 PST
<rdar://problem/87719729>
Alex Christensen
Comment 8 2022-01-18 10:37:40 PST
Internal commit 0f5ee832212f7d5b552bb117c1428dc65c563f7e
Alex Christensen
Comment 9 2022-01-18 10:46:36 PST
Reopening to attach new patch.
Alex Christensen
Comment 10 2022-01-18 10:46:41 PST
Created attachment 449403 [details] Patch
EWS
Comment 11 2022-01-18 11:37:21 PST
Committed r288133 (246140@main): <https://commits.webkit.org/246140@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449403 [details].
Note You need to log in before you can comment on or make changes to this bug.