Bug 235169

Summary: [macOS WK1] fast/canvas/large-getImageData.html is consistently failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: CanvasAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, mmaxfield, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234321
Attachments:
Description Flags
Patch none

Description Ryan Haddad 2022-01-12 17:38:19 PST 
fast/canvas/large-getImageData.html has been consistently failing on macOS WK1 bots since it was added with https://trac.webkit.org/changeset/287805/webkit

--- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/fast/canvas/large-getImageData-expected.txt
+++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/fast/canvas/large-getImageData-actual.txt
@@ -1,5 +1,7 @@
-PASS large getImageData worked
+CONSOLE MESSAGE: Total canvas memory use exceeds the maximum limit (64 MB).
+FAIL large getImageData threw
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
 

https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Flarge-getImageData.html
Comment 1 Radar WebKit Bug Importer 2022-01-12 17:38:32 PST 
<rdar://problem/87523265>
Comment 2 Ryan Haddad 2022-01-12 17:38:38 PST 
Myles, is this expected to fail on WK1?
Comment 3 Myles C. Maxfield 2022-01-12 19:21:34 PST 
Oh yes this will fail on WK1. We should add a skip (not flakey!) line to TestExpectations.
Comment 4 Ryan Haddad 2022-01-13 09:11:02 PST 
(In reply to Myles C. Maxfield from comment #3)
> Oh yes this will fail on WK1. We should add a skip (not flakey!) line to
> TestExpectations.
Would you please take care of this? Thanks!
Comment 5 Myles C. Maxfield 2022-01-13 10:17:50 PST 
Created attachment 449078 [details]
Patch
Comment 6 Alexey Proskuryakov 2022-01-14 16:33:43 PST 
Is this good to go?
Comment 7 Myles C. Maxfield 2022-01-14 20:06:35 PST 
(In reply to Alexey Proskuryakov from comment #6)
> Is this good to go?

Checking now...
Comment 8 Myles C. Maxfield 2022-01-14 20:11:10 PST 
Yes.
Comment 9 Myles C. Maxfield 2022-01-14 20:16:37 PST 
Committed r288051 (246071@trunk): <https://commits.webkit.org/246071@trunk>