Bug 235125

Summary:

Add post-commit build to run accessibility isolated tree mode layout tests

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Tools / Tests

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, aboxhall, andresg_22, apinheiro, ap, cfleizach, dmazzoni, ews-watchlist, jbedard, jcraig, jdiggs, ryanhaddad, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Tyler Wilcock

Reported 2022-01-12 11:14:17 PST

Add Big Sur post-commit build to run accessibility isolated tree mode layout tests.

Attachments
Patch (4.98 KB, patch) 2022-01-12 11:20 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (4.98 KB, patch) 2022-01-13 19:42 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (8.01 KB, patch) 2022-01-20 09:12 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (7.98 KB, patch) 2022-01-20 09:17 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (5.66 KB, patch) 2022-01-20 09:28 PST, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (3.04 KB, patch) 2022-06-10 11:31 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (4.43 KB, patch) 2022-06-10 11:45 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (4.39 KB, patch) 2022-06-10 11:49 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Tyler Wilcock

Comment 1 2022-01-12 11:20:44 PST

Created attachment 448973 [details] Patch

Tyler Wilcock

Comment 2 2022-01-12 11:22:02 PST

Comment on attachment 448973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448973&action=review > Tools/CISupport/build-webkit-org/config.json:248 > + "additionalArguments": ["--no-retry-failures", "--accessibility-isolated-tree", "accessibility/"], Is specifying "accessibility/" in additionalArguments a fine way to only run accessibility tests on this builder? > Tools/CISupport/build-webkit-org/config.json:249 > + "workernames": ["bot302"] What bot should I use for this new builder?

Tyler Wilcock

Comment 3 2022-01-13 19:42:43 PST

Created attachment 449129 [details] Patch

Radar WebKit Bug Importer

Comment 4 2022-01-19 11:20:33 PST

<rdar://problem/87781868>

Aakash Jain

Comment 5 2022-01-19 17:47:45 PST

Also need to change "platform" for bot179 in config.json to "mac-bigsur". That would also fix red services ews status-bubble. Sample run: https://build.webkit-dev.org/#/builders/120/builds/2

Aakash Jain

Comment 6 2022-01-19 18:46:19 PST

Comment on attachment 449129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449129&action=review > Tools/CISupport/build-webkit-org/config.json:246 > + { "name": "Apple-BigSur-Release-WK2-Accessibility-Isolated-Tree-Tests", "factory": "TestAllButJSCFactory", "builddir": "bigsur-release-tests-wk2-accessibility-isolated-tree", To run just the layout tests, you can replace TestAllButJSCFactory with TestLayoutFactory. Sample run: https://build.webkit-dev.org/#/builders/120/builds/4

Tyler Wilcock

Comment 7 2022-01-20 09:12:15 PST

Created attachment 449588 [details] Patch

Tyler Wilcock

Comment 8 2022-01-20 09:17:31 PST

Created attachment 449589 [details] Patch

Tyler Wilcock

Comment 9 2022-01-20 09:28:05 PST

Created attachment 449591 [details] Patch

Tyler Wilcock

Comment 10 2022-06-10 11:31:06 PDT

Created attachment 460164 [details] Patch