Summary: | Build WebKitSwift when building with make or build-webkit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | REOPENED --- | ||||||||
Severity: | Normal | CC: | ap, emw, eric.carlson, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 235324 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alex Christensen
2022-01-11 20:03:17 PST
Created attachment 448900 [details]
Patch
Comment on attachment 448900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448900&action=review > Source/WebKit/ChangeLog:9 > + For various internal reasons, we have to have no depency between the two, > + but we command line builders want to build and test it just like everyone else. Not sure if I know all of the internal reasons, but typically, we add new Xcode projects, not add independent targets to existing ones. Is there a reason why this case has to be different? > Makefile.shared:113 > + $1 xcodebuild $2 $(OTHER_OPTIONS) $(XCODE_TARGET) $(XCODE_OPTIONS) $3 $(WEBKIT_ADDITIONAL_XCODE_MAKEFILE_ARGS) | $(OUTPUT_FILTER) && exit $${PIPESTATUS[0]} \ This new variable is vaguely named, but looks like we can just use XCODE_TARGET? Created attachment 448970 [details]
Patch
Comment on attachment 448970 [details]
Patch
Seems fine as a temporary approach, as discussed on Slack.
Comment on attachment 448970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448970&action=review > Source/WebKit/ChangeLog:9 > + but we command line builders want to build and test it just like everyone else. Do you mean "but *the* command line builders"? I am a command line builder because I use the command line to build WebKit more often than building from within Xcode. I believe there are several of us. Committed r287944 (245973@main): <https://commits.webkit.org/245973@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448970 [details]. Monterey builds appear to be failing with errors in WKGroupSession.swift after this change: https://build.webkit.org/#/builders/368/builds/1643/steps/8/logs/stdio Reverted r287944 for reason: Breaks Monterey build. Committed r287964 (245993@trunk): <https://commits.webkit.org/245993@trunk> ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Reverted in http://trac.webkit.org/r288214 |