Bug 235059

Summary: Fixed installhdr build failures in WebCore and WebKitLegacy
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+, ap: commit-queue-

Michael Saboff
Reported 2022-01-10 21:54:50 PST
When building with a SYSTEM_CONTENT_PATH, we fail when building WebCore in the install headers phase. warning: duplicate output file '/Library/Caches/com.apple.xbs/Binaries/WebCore/installhdrs/Root/System/Library/PrivateFrameworks/WebCore.framework' on task: PhaseScriptExecution Create Symlink to Alt Root Path /Library/Caches/com.apple.xbs/Binaries/WebCore/installhdrs/TempContent/Objects/WebCore.build/WebCore.build/Script-6577FFC7276AC9AD0011AEC8.sh (in target 'WebCore' from project 'WebCore') ** INSTALL HEADERS FAILED **
Attachments
Patch (13.70 KB, patch)
2022-01-10 22:21 PST, Michael Saboff 		fpizlo: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2022-01-10 22:02:02 PST
<rdar://87206692>
Michael Saboff
Comment 2 2022-01-10 22:21:49 PST
Created attachment 448831 [details] Patch
Alexey Proskuryakov
Comment 3 2022-01-10 22:26:46 PST
Comment on attachment 448831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448831&action=review > Source/WebKitLegacy/scripts/create-symlink-to-altroot.sh:1 > +#!/bin/zsh We shouldn't be using zsh in scripts. /bin/sh is the standard.
Michael Saboff
Comment 4 2022-01-10 22:33:15 PST
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 448831 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448831&action=review > > > Source/WebKitLegacy/scripts/create-symlink-to-altroot.sh:1 > > +#!/bin/zsh > > We shouldn't be using zsh in scripts. /bin/sh is the standard. I'll revert back to /bin/sh.
Michael Saboff
Comment 5 2022-01-11 09:55:18 PST
Committed r287884 (245927@trunk): <https://commits.webkit.org/245927@trunk>
Note You need to log in before you can comment on or make changes to this bug.