Bug 235058

Summary:

automatic minimum block-size aspect-ratio rules should not apply to replaced elements

Product:

WebKit

Reporter:

Cameron McCormack (:heycam) <heycam>

Component:

Layout and Rendering

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cathiechen, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Cameron McCormack (:heycam)

Reported 2022-01-10 19:57:34 PST

We apply the https://www.w3.org/TR/css-sizing-4/#aspect-ratio-minimum rule in RenderBox::constrainLogicalHeightByMinMax and RenderBox::constrainLogicalWidthInFragmentByMinMax, but we don't correctly check first that the element is non-replaced. For RenderBox::constrainLogicalHeightByMinMax, this can have the effect of increasing the computed min-height of a replaced element with an aspect-ratio to intrinsicContentHeight, if the element has a child. (The code that increases the automatic min-height to at least intrinsicContentHeight seems to be part of the unwritten rules about how `min-content: auto` applies to block elements.) Normally, replaced elements don't have children, but the way we check (looking at `firstChild()`) can return true for <video> elements with controls, <img> elements that have text recognition overlays, and possibly other cases where a UA shadow root has been attached.

Attachments
Patch (7.11 KB, patch) 2022-01-10 21:18 PST, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Patch (7.18 KB, patch) 2022-01-12 15:51 PST, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.