| Summary: | Remove unused Document::ListenerType enumerators | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||
| Component: | DOM | Assignee: | Alexey Shvayka <ashvayka> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Shvayka
2022-01-10 15:09:13 PST
Created attachment 448804 [details]
Patch
Comment on attachment 448804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review > Source/WebCore/ChangeLog:9 > + Except for RESIZE_LISTENER, which just seems to be left behind, legacyType() of EventTarget.cpp > + handles all other event types, deleted in this patch, according to the spec [1]. We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old. Comment on attachment 448804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review >> Source/WebCore/ChangeLog:9 >> + handles all other event types, deleted in this patch, according to the spec [1]. > > We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old. strange, not stream, thanks autocorrect (or my brain) Did I forget to set review+? Oops! Committed r288584 (246406@trunk): <https://commits.webkit.org/246406@trunk> Thanks Darin and Sam! (In reply to Darin Adler from comment #2) > We could also change this to an OptionSet some day, and STOP USING ALL > CAPITAL LETTERS FOR IT. The style being so stream is just because this is > really old. That would be nice, added a FIXME. |