Bug 235049

Summary: Remove unused Document::ListenerType enumerators
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: DOMAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch sam: review+

Alexey Shvayka
Reported 2022-01-10 15:09:13 PST
Remove unused Document::ListenerType enumerators
Attachments
Patch (4.41 KB, patch)
2022-01-10 15:13 PST, Alexey Shvayka 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2022-01-10 15:13:16 PST
Created attachment 448804 [details] Patch
Darin Adler
Comment 2 2022-01-10 18:02:32 PST
Comment on attachment 448804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review > Source/WebCore/ChangeLog:9 > + Except for RESIZE_LISTENER, which just seems to be left behind, legacyType() of EventTarget.cpp > + handles all other event types, deleted in this patch, according to the spec [1]. We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old.
Darin Adler
Comment 3 2022-01-10 18:02:55 PST
Comment on attachment 448804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review >> Source/WebCore/ChangeLog:9 >> + handles all other event types, deleted in this patch, according to the spec [1]. > > We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old. strange, not stream, thanks autocorrect (or my brain)
Darin Adler
Comment 4 2022-01-11 08:40:38 PST
Did I forget to set review+? Oops!
Radar WebKit Bug Importer
Comment 5 2022-01-17 15:10:18 PST
<rdar://problem/87689367>
Alexey Shvayka
Comment 6 2022-01-25 14:09:15 PST
Committed r288584 (246406@trunk): <https://commits.webkit.org/246406@trunk>
Alexey Shvayka
Comment 7 2022-01-25 14:10:15 PST
Thanks Darin and Sam! (In reply to Darin Adler from comment #2) > We could also change this to an OptionSet some day, and STOP USING ALL > CAPITAL LETTERS FOR IT. The style being so stream is just because this is > really old. That would be nice, added a FIXME.
Note You need to log in before you can comment on or make changes to this bug.