| Summary: | [LFC][IFC] Introduce a dedicated structure for Line::Run's trailing whitespace information | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 448689 [details]
Patch
Comment on attachment 448689 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448689&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLine.h:160 > + TrailingWhitespace m_trailingWhitespace { }; I suppose std::optional<TrailingWhitespace> without the None value would be an alternative. (In reply to Antti Koivisto from comment #2) > Comment on attachment 448689 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448689&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLine.h:160 > > + TrailingWhitespace m_trailingWhitespace { }; > > I suppose std::optional<TrailingWhitespace> without the None value would be > an alternative. Good point! Created attachment 448701 [details]
Patch
Committed r287824 (245876@main): <https://commits.webkit.org/245876@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448701 [details]. |
- TrailingWhitespace m_trailingWhitespaceType { TrailingWhitespace::None }; - InlineLayoutUnit m_trailingWhitespaceWidth { 0 }; + TrailingWhitespace m_trailingWhitespace { };