Bug 235010 – [LFC][IFC] Introduce a dedicated structure for Line::Run's trailing whitespace information

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

-        TrailingWhitespace m_trailingWhitespaceType { TrailingWhitespace::None };
-        InlineLayoutUnit m_trailingWhitespaceWidth { 0 };
+        TrailingWhitespace m_trailingWhitespace { };

[zalan]

Created attachment 448689 [details]
Patch

[Antti Koivisto]

Comment on attachment 448689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448689&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLine.h:160
> +        TrailingWhitespace m_trailingWhitespace { };

I suppose std::optional<TrailingWhitespace> without the None value would be an alternative.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 448689 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448689&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLine.h:160
> > +        TrailingWhitespace m_trailingWhitespace { };
> 
> I suppose std::optional<TrailingWhitespace> without the None value would be
> an alternative.
Good point!

[zalan]

Created attachment 448701 [details]
Patch

[EWS]

Committed r287824 (245876@main): <https://commits.webkit.org/245876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448701 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87312941>