Bug 235010

Summary: [LFC][IFC] Introduce a dedicated structure for Line::Run's trailing whitespace information
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2022-01-08 17:39:29 PST
-        TrailingWhitespace m_trailingWhitespaceType { TrailingWhitespace::None };
-        InlineLayoutUnit m_trailingWhitespaceWidth { 0 };
+        TrailingWhitespace m_trailingWhitespace { };
Comment 1 zalan 2022-01-08 17:40:54 PST
Created attachment 448689 [details]
Patch
Comment 2 Antti Koivisto 2022-01-08 23:03:09 PST
Comment on attachment 448689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448689&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLine.h:160
> +        TrailingWhitespace m_trailingWhitespace { };

I suppose std::optional<TrailingWhitespace> without the None value would be an alternative.
Comment 3 zalan 2022-01-09 06:16:25 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 448689 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448689&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLine.h:160
> > +        TrailingWhitespace m_trailingWhitespace { };
> 
> I suppose std::optional<TrailingWhitespace> without the None value would be
> an alternative.
Good point!
Comment 4 zalan 2022-01-09 07:07:09 PST
Created attachment 448701 [details]
Patch
Comment 5 EWS 2022-01-09 10:24:00 PST
Committed r287824 (245876@main): <https://commits.webkit.org/245876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448701 [details].
Comment 6 Radar WebKit Bug Importer 2022-01-09 10:25:19 PST
<rdar://problem/87312941>