Summary: | Remove support for Direct2D / FTW | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, jer.noble, kbr, keith_miller, kondapallykalyan, luiz, mark.lam, mmaxfield, msaboff, pdr, philipj, ryuan.choi, saam, sabouhallawa, schenney, sergio, simon.fraser, tzagallo, webkit-bug-importer, zeno | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=235097 | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 235054 | ||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2022-01-07 18:28:53 PST
Created attachment 448658 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Created attachment 448671 [details]
Patch
Created attachment 448672 [details]
Patch
Created attachment 448673 [details]
Patch
Created attachment 448675 [details]
Patch
Created attachment 448687 [details]
Patch
Created attachment 448691 [details]
Patch
Created attachment 448709 [details]
Patch
Brent, I believe you added the FTW build, so I want to double check that you are on board with this (my memory is that the last time I asked you were). The code has not built in a long time at this point, and has bit-rotted quite a bit. I keep accidentally trying to make changes in Direct2D files as part of refactors only to realize they don't actually compile at all. (In reply to Sam Weinig from comment #10) > Brent, I believe you added the FTW build, so I want to double check that you > are on board with this (my memory is that the last time I asked you were). > > The code has not built in a long time at this point, and has bit-rotted > quite a bit. I keep accidentally trying to make changes in Direct2D files as > part of refactors only to realize they don't actually compile at all. Yes, this was a cool idea that I can’t work on at a meaningful level, and that no one else wanted to help with. The code will always be available in the repo, so we could revive it if someone wanted to do so. Please remove this old code. Thank you for doing this work! Committed r287829 (245881@main): <https://commits.webkit.org/245881@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448709 [details]. |