Bug 234999

Summary: Remove support for Direct2D / FTW
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, jer.noble, kbr, keith_miller, kondapallykalyan, luiz, mark.lam, mmaxfield, msaboff, pdr, philipj, ryuan.choi, saam, sabouhallawa, schenney, sergio, simon.fraser, tzagallo, webkit-bug-importer, zeno
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235097
Bug Depends on:    
Bug Blocks: 235054    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Sam Weinig
Reported 2022-01-07 18:28:53 PST
Remove support for Direct2D
Attachments
Patch (469.96 KB, patch)
2022-01-07 18:40 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (469.96 KB, patch)
2022-01-08 09:44 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (470.12 KB, patch)
2022-01-08 10:13 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (471.96 KB, patch)
2022-01-08 10:40 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (473.08 KB, patch)
2022-01-08 11:13 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (490.56 KB, patch)
2022-01-08 17:29 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (493.35 KB, patch)
2022-01-08 18:09 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (494.14 KB, patch)
2022-01-09 09:43 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2022-01-07 18:40:10 PST Comment hidden (obsolete)
EWS Watchlist
Comment 2 2022-01-07 18:41:41 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Sam Weinig
Comment 3 2022-01-08 09:44:57 PST Comment hidden (obsolete)
Sam Weinig
Comment 4 2022-01-08 10:13:27 PST Comment hidden (obsolete)
Sam Weinig
Comment 5 2022-01-08 10:40:00 PST Comment hidden (obsolete)
Sam Weinig
Comment 6 2022-01-08 11:13:14 PST Comment hidden (obsolete)
Sam Weinig
Comment 7 2022-01-08 17:29:48 PST Comment hidden (obsolete)
Sam Weinig
Comment 8 2022-01-08 18:09:25 PST Comment hidden (obsolete)
Sam Weinig
Comment 9 2022-01-09 09:43:07 PST
Created attachment 448709 [details] Patch
Sam Weinig
Comment 10 2022-01-09 09:45:29 PST
Brent, I believe you added the FTW build, so I want to double check that you are on board with this (my memory is that the last time I asked you were). The code has not built in a long time at this point, and has bit-rotted quite a bit. I keep accidentally trying to make changes in Direct2D files as part of refactors only to realize they don't actually compile at all.
Brent Fulgham
Comment 11 2022-01-09 13:15:47 PST
(In reply to Sam Weinig from comment #10) > Brent, I believe you added the FTW build, so I want to double check that you > are on board with this (my memory is that the last time I asked you were). > > The code has not built in a long time at this point, and has bit-rotted > quite a bit. I keep accidentally trying to make changes in Direct2D files as > part of refactors only to realize they don't actually compile at all. Yes, this was a cool idea that I can’t work on at a meaningful level, and that no one else wanted to help with. The code will always be available in the repo, so we could revive it if someone wanted to do so. Please remove this old code. Thank you for doing this work!
EWS
Comment 12 2022-01-09 19:40:44 PST
Committed r287829 (245881@main): <https://commits.webkit.org/245881@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448709 [details].
Radar WebKit Bug Importer
Comment 13 2022-01-09 19:41:22 PST
<rdar://problem/87320559>
Note You need to log in before you can comment on or make changes to this bug.