| Summary: | Null pointer crash when calling into `-[WebView close]` in `-webView:didCommitLoadForFrame:` | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, ggaren, japhet, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2022-01-07 16:12:47 PST
Created attachment 448645 [details]
For EWS
LGTM (In reply to Geoffrey Garen from comment #2) > LGTM Thanks for taking a look! (I held off on adding the r? because I wasn't sure if there were going to be more unified-source-related build failures on iOS, but it seems like EWS is happy now :P) Comment on attachment 448645 [details]
For EWS
r=me
(In reply to Chris Dumez from comment #4) > Comment on attachment 448645 [details] > For EWS > > r=me Thanks for the reviews! It looks like my new test is crashing on iOS — upon closer investigation though, it seems that it's just crashing on initialization of the WebView: ``` Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 JavaScriptCore 0x10b654d53 WTFCrashWithInfo(int, char const*, char const*, int) + 19 (Assertions.h:732) 1 JavaScriptCore 0x10b310503 JSC::(anonymous namespace)::sizeClasses() + 58 (MarkedSpace.cpp:138) [inlined] 2 JavaScriptCore 0x10b310503 void JSC::(anonymous namespace)::buildSizeClassTable<std::__1::array<unsigned int, 503ul>, JSC::MarkedSpace::initializeSizeClassForStepSize()::$_5::operator()() const::'lambda'(unsigned long), JSC::MarkedSpace::initializeSizeClassForStepSize()::$_5::operator()() const::'lambda0'(unsigned long)>(std::__1::array<unsigned int, 503ul>&, JSC::MarkedSpace::initializeSizeClassForStepSize()::$_5::operator()() const::'lambda'(unsigned long) const&, JSC::MarkedSpace::initializeSizeClassForStepSize()::$_5::operator()() const::'lambda0'(unsigned long) const&) + 58 (MarkedSpace.cpp:147) [inlined] ``` Taking a look at similar legacy WK1 API tests that use WebView, it seems they're all macOS-specific, so it seems WK1's WebView just wasn't intended to be used in this way on iOS. I'll move the new test to `Tests/mac` before landing (and remove some of the unified source related fixes that are no longer needed). Created attachment 448680 [details]
For EWS
Committed r287814 (245866@main): <https://commits.webkit.org/245866@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448680 [details]. |