| Summary: | A/B comparison tests fail trying to look up fuzzy match tolerance | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | akeerthi, dino, ews-watchlist, glenn, jbedard, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2022-01-07 11:52:34 PST
Created attachment 448615 [details]
Patch
Comment on attachment 448615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448615&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:416 > + fuzzy_tolerance = None > + if allow_fuzzy_tolerance: > + fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename) Not sure what our Python style guide says, but ternary might be nice: `fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename) if allow_fuzzy_tolerance else None`. Not sure about our Python style guide either, but personally I'm not a big fan of the out-of-order-shortcutting in the trailing style ternary operator. Committed r287790 (245850@main): <https://commits.webkit.org/245850@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448615 [details]. |