Bug 234937

Summary: Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters (v2)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234213
Attachments:
Description Flags
Patch
thorton: review+, ews-feeder: commit-queue-
Patch none

Simon Fraser (smfr)
Reported 2022-01-06 13:59:27 PST
Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters (v2)
Attachments
Patch (20.19 KB, patch)
2022-01-06 14:10 PST, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.09 KB, patch)
2022-01-06 15:46 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2022-01-06 14:10:59 PST
Created attachment 448536 [details] Patch
Tim Horton
Comment 2 2022-01-06 14:36:06 PST
Comment on attachment 448536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448536&action=review > Source/WebCore/ChangeLog:8 > + Refine the logic added in r286932, which tries ensure that the scrolling thread commits a "tries ensure" > Source/WebCore/page/Page.h:617 > + void scheduledRenderingUpdate(); "didSchedule"? (initially I didn't notice the -ed and thought this was a parameterless version of the line above)
Simon Fraser (smfr)
Comment 3 2022-01-06 15:46:24 PST
Created attachment 448542 [details] Patch
EWS
Comment 4 2022-01-06 20:57:50 PST
Committed r287739 (245809@main): <https://commits.webkit.org/245809@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448542 [details].
Radar WebKit Bug Importer
Comment 5 2022-01-06 20:58:52 PST
<rdar://problem/87233606>
Note You need to log in before you can comment on or make changes to this bug.