Bug 234930

Summary: Separate "linked-on-or-{before, after}-everything" override from the SDK version
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, akeerthi, benjamin, cdumez, cmarcelo, darin, ews-watchlist, hi, megan_gardner, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Tim Horton
Reported 2022-01-06 12:11:15 PST
Separate "linked-on-or-{before, after}-everything" override from the SDK version
Attachments
Patch (15.88 KB, patch)
2022-01-06 12:12 PST, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.75 KB, patch)
2022-01-06 14:16 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2022-01-06 12:12:12 PST
Created attachment 448524 [details] Patch
Tim Horton
Comment 2 2022-01-06 14:16:07 PST
Created attachment 448537 [details] Patch
EWS
Comment 3 2022-01-06 15:41:00 PST
Committed r287720 (245803@main): <https://commits.webkit.org/245803@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448537 [details].
Radar WebKit Bug Importer
Comment 4 2022-01-06 15:42:23 PST
<rdar://problem/87222930>
Darin Adler
Comment 5 2022-01-06 16:13:19 PST
Comment on attachment 448537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448537&action=review > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53 > + static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter; I don’t think std::optional needs NeverDestroyed; pretty sure you can just use a global here.
Tim Horton
Comment 6 2022-01-06 16:58:09 PST
(In reply to Darin Adler from comment #5) > Comment on attachment 448537 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448537&action=review > > > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53 > > + static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter; > > I don’t think std::optional needs NeverDestroyed; pretty sure you can just > use a global here. Good... point. I was following the one above, but there's a pretty good chance that one is my fault too :)
Tim Horton
Comment 7 2022-01-06 18:19:39 PST
(In reply to Tim Horton from comment #6) > (In reply to Darin Adler from comment #5) > > Comment on attachment 448537 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=448537&action=review > > > > > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53 > > > + static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter; > > > > I don’t think std::optional needs NeverDestroyed; pretty sure you can just > > use a global here. > > Good... point. I was following the one above, but there's a pretty good > chance that one is my fault too :) I am drive-by fixing both in https://bugs.webkit.org/show_bug.cgi?id=234942
Note You need to log in before you can comment on or make changes to this bug.