| Summary: | Separate "linked-on-or-{before, after}-everything" override from the SDK version | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, akeerthi, benjamin, cdumez, cmarcelo, darin, ews-watchlist, hi, megan_gardner, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 448524 [details]
Patch
Created attachment 448537 [details]
Patch
Committed r287720 (245803@main): <https://commits.webkit.org/245803@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448537 [details]. Comment on attachment 448537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448537&action=review > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53 > + static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter; I don’t think std::optional needs NeverDestroyed; pretty sure you can just use a global here. (In reply to Darin Adler from comment #5) > Comment on attachment 448537 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448537&action=review > > > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53 > > + static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter; > > I don’t think std::optional needs NeverDestroyed; pretty sure you can just > use a global here. Good... point. I was following the one above, but there's a pretty good chance that one is my fault too :) (In reply to Tim Horton from comment #6) > (In reply to Darin Adler from comment #5) > > Comment on attachment 448537 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=448537&action=review > > > > > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53 > > > + static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter; > > > > I don’t think std::optional needs NeverDestroyed; pretty sure you can just > > use a global here. > > Good... point. I was following the one above, but there's a pretty good > chance that one is my fault too :) I am drive-by fixing both in https://bugs.webkit.org/show_bug.cgi?id=234942 |
Separate "linked-on-or-{before, after}-everything" override from the SDK version