Bug 234902

Summary:

Order Web Inspector reference pages by column

Product:

WebKit

Reporter:

Jon Davis <jond>

Component:

WebKit Website

Assignee:

Jon Davis <jond>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jond, ntim, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ntim: review-

Description Jon Davis 2022-01-05 15:17:41 PST

Change to a two-column layout for the Web Inspector reference page archive.

Comment 1 Jon Davis 2022-01-05 15:40:11 PST

Created attachment 448446 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2022-01-12 15:18:13 PST

<rdar://problem/87490549>

Comment 3 Tim Nguyen (:ntim) 2022-02-11 00:40:33 PST

Comment on attachment 448446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448446&action=review

> Websites/webkit.org/wp-content/themes/webkit/archive-web_inspector_page.php:159
> +            column-count: 2;

You might want to define a column-width value as well. Right now, this isn't responsive at small sizes, and you have 2 tiny columns (instead of 1 as currently implemented).

This also needs clean up: https://webkit-search.igalia.com/webkit/rev/38492c3c32c73865ca2d477ef03721b87399b24f/Websites/webkit.org/wp-content/themes/webkit/archive-web_inspector_page.php#216-223

Comment 4 Jon Davis 2022-11-01 14:36:13 PDT

Pull request: https://github.com/WebKit/WebKit/pull/6007

Comment 5 EWS 2022-11-01 14:45:53 PDT

Committed 256198@main (a4803a432bbc): <https://commits.webkit.org/256198@main>

Reviewed commits have been landed. Closing PR #6007 and removing active labels.