Bug 234869

Summary: Refactor CSS property parsing helpers to be a bit more composable
Product: WebKit Reporter: Sam Weinig <sam>
Component: CSSAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
ews-feeder: commit-queue-
Patch
darin: review+
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Sam Weinig 2022-01-04 19:10:15 PST 
We are approaching a combinatorial problem with all the consumeNumberAndAngleRaw..., etc functions. We can do better.
Comment 1 Sam Weinig 2022-01-04 19:10:52 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2022-01-08 18:09:22 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2022-01-08 19:13:55 PST 
Created attachment 448692 [details]
Patch
Comment 4 Darin Adler 2022-01-09 08:50:53 PST 
Comment on attachment 448692 [details]
Patch

Not a fan of "impl", always trying to avoid using that word.
Comment 5 Sam Weinig 2022-01-09 09:20:11 PST 
(In reply to Darin Adler from comment #4)
> Comment on attachment 448692 [details]
> Patch
> 
> Not a fan of "impl", always trying to avoid using that word.

Yeah, me either. Replaced MetaConsumerImpl with MetaConsumerDispatcher.
Comment 6 Sam Weinig 2022-01-09 09:22:53 PST Comment hidden (obsolete)
Comment 7 EWS 2022-01-09 09:24:02 PST Comment hidden (obsolete)
Comment 8 Sam Weinig 2022-01-09 09:34:36 PST Comment hidden (obsolete)
Comment 9 Sam Weinig 2022-01-09 10:03:01 PST Comment hidden (obsolete)
Comment 10 Sam Weinig 2022-01-09 10:16:02 PST Comment hidden (obsolete)
Comment 11 EWS 2022-01-09 10:19:31 PST Comment hidden (obsolete)
Comment 12 EWS 2022-01-09 10:55:38 PST 
Committed r287825 (245877@main): <https://commits.webkit.org/245877@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448712 [details].
Comment 13 Radar WebKit Bug Importer 2022-01-09 10:56:19 PST 
<rdar://problem/87313403>