Bug 234869

Summary:

Refactor CSS property parsing helpers to be a bit more composable

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

CSS

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Patch	ews-feeder: commit-queue-
Patch	darin: review+
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Sam Weinig

Reported 2022-01-04 19:10:15 PST

We are approaching a combinatorial problem with all the consumeNumberAndAngleRaw..., etc functions. We can do better.

Attachments
WIP (106.74 KB, patch) 2022-01-04 19:10 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (141.20 KB, patch) 2022-01-08 18:09 PST, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (144.32 KB, patch) 2022-01-08 19:13 PST, Sam Weinig	darin: review+	Details Formatted Diff Diff
Patch (146.47 KB, patch) 2022-01-09 09:22 PST, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (144.43 KB, patch) 2022-01-09 09:34 PST, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (144.45 KB, patch) 2022-01-09 10:03 PST, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (144.45 KB, patch) 2022-01-09 10:16 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2022-01-04 19:10:52 PST Comment hidden (obsolete)

Created attachment 448358 [details] WIP

Sam Weinig

Comment 2 2022-01-08 18:09:22 PST Comment hidden (obsolete)

Created attachment 448690 [details] Patch

Sam Weinig

Comment 3 2022-01-08 19:13:55 PST

Created attachment 448692 [details] Patch

Darin Adler

Comment 4 2022-01-09 08:50:53 PST

Comment on attachment 448692 [details] Patch Not a fan of "impl", always trying to avoid using that word.

Sam Weinig

Comment 5 2022-01-09 09:20:11 PST

(In reply to Darin Adler from comment #4) > Comment on attachment 448692 [details] > Patch > > Not a fan of "impl", always trying to avoid using that word. Yeah, me either. Replaced MetaConsumerImpl with MetaConsumerDispatcher.

Sam Weinig

Comment 6 2022-01-09 09:22:53 PST Comment hidden (obsolete)

Created attachment 448704 [details] Patch

EWS

Comment 7 2022-01-09 09:24:02 PST Comment hidden (obsolete)

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Sam Weinig

Comment 8 2022-01-09 09:34:36 PST Comment hidden (obsolete)

Created attachment 448708 [details] Patch

Sam Weinig

Comment 9 2022-01-09 10:03:01 PST Comment hidden (obsolete)

Created attachment 448710 [details] Patch