Bug 234864

Summary: Rename Vector and FixedVector::findMatching to findIf to match stl naming.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, kangil.han, keith_miller, kondapallykalyan, luiz, menard, mifenton, mmaxfield, msaboff, pangle, philipj, pnormand, saam, samuel_white, sergio, simon.fraser, tommyw, tonikitoo, tzagallo, vjaquez, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234855    
Bug Blocks:    
Attachments:
Description Flags
work in progress.
ews-feeder: commit-queue-
work in progress.
none
proposed patch.
ysuzuki: review+
patch for landing. none

Comment 1 Mark Lam 2022-01-04 17:16:30 PST 
Also do reverseFindMatching.
Comment 2 Mark Lam 2022-01-04 17:28:22 PST 
Created attachment 448352 [details]
work in progress.
Comment 3 EWS Watchlist 2022-01-04 17:29:15 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Mark Lam 2022-01-04 17:42:22 PST 
Created attachment 448354 [details]
work in progress.
Comment 5 Radar WebKit Bug Importer 2022-01-11 16:09:18 PST 
<rdar://problem/87424746>
Comment 6 Mark Lam 2022-01-24 13:58:07 PST 
Created attachment 449854 [details]
proposed patch.
Comment 7 Yusuke Suzuki 2022-01-24 14:00:01 PST 
Comment on attachment 449854 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=449854&action=review

r=me

> Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp:160
>  TEST(WTF_FixedVector, FindMatching)

Rename this test to FindIf.
Comment 8 Mark Lam 2022-01-24 14:05:13 PST 
Created attachment 449855 [details]
patch for landing.

Thanks for the review.
Comment 9 EWS 2022-01-24 22:16:43 PST 
Committed r288541 (246373@main): <https://commits.webkit.org/246373@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449855 [details].