Bug 234858 – REGRESSION (r287374): ASSERTION FAILED: m_sessionID under WebKit::WebProcess::updateProcessName()

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

Many API tests are failing the following assertion on Monterey bots: 

        ASSERTION FAILED: m_sessionID
        /Volumes/Data/worker/monterey-debug/build/Source/WebKit/WebProcess/WebProcess.cpp(1136) : WebKit::NetworkProcessConnection &WebKit::WebProcess::ensureNetworkProcessConnection()
        1   0x14e1cd2e0 WTFCrash
        2   0x128ab4c3c auto WTF::makeBlockPtr<-[_WKCustomHeaderFields setFields:]::$_0, -[_WKCustomHeaderFields setFields:]::$_0, void, objc_object*, objc_object*, bool*>(-[_WKCustomHeaderFields setFields:]::$_0&&, void (-[_WKCustomHeaderFields setFields:]::$_0::*)(objc_object*, objc_object*, bool*) const)
        3   0x12aa00a38 WebKit::WebProcess::ensureNetworkProcessConnection()
        4   0x12a56e720 WebKit::WebProcess::updateProcessName(WebKit::WebProcess::IsInProcessInitialization)
        5   0x12a56de64 WebKit::WebProcess::platformInitializeWebProcess(WebKit::WebProcessCreationParameters&)
        6   0x12a9ff100 WebKit::WebProcess::initializeWebProcess(WebKit::WebProcessCreationParameters&&)
        7   0x12b48d740 void IPC::callMemberFunctionImpl<WebKit::WebProcess, void (WebKit::WebProcess::*)(WebKit::WebProcessCreationParameters&&), std::__1::tuple<WebKit::WebProcessCreationParameters>, 0ul>(WebKit::WebProcess*, void (WebKit::WebProcess::*)(WebKit::WebProcessCreationParameters&&), std::__1::tuple<WebKit::WebProcessCreationParameters>&&, std::__1::integer_sequence<unsigned long, 0ul>)
        8   0x12b48c740 void IPC::callMemberFunction<WebKit::WebProcess, void (WebKit::WebProcess::*)(WebKit::WebProcessCreationParameters&&), std::__1::tuple<WebKit::WebProcessCreationParameters>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebKit::WebProcessCreationParameters>&&, WebKit::WebProcess*, void (WebKit::WebProcess::*)(WebKit::WebProcessCreationParameters&&))
        9   0x12b48765c void IPC::handleMessage<Messages::WebProcess::InitializeWebProcess, WebKit::WebProcess, void (WebKit::WebProcess::*)(WebKit::WebProcessCreationParameters&&)>(IPC::Connection&, IPC::Decoder&, WebKit::WebProcess*, void (WebKit::WebProcess::*)(WebKit::WebProcessCreationParameters&&))
        10  0x12b485cec WebKit::WebProcess::didReceiveWebProcessMessage(IPC::Connection&, IPC::Decoder&)
        11  0x12aa01f10 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        12  0x129f4b4b0 IPC::Connection::dispatchMessage(IPC::Decoder&)
        13  0x129f4bb78 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
        14  0x129f4c148 IPC::Connection::dispatchOneIncomingMessage()
        15  0x129f697d0 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()()
        16  0x129f696e0 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call()
        17  0x14e1f5124 WTF::Function<void ()>::operator()() const
        18  0x14e27d0d0 WTF::RunLoop::performWork()
        19  0x14e281a14 WTF::RunLoop::performWork(void*)
        20  0x185c84bbc __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
        21  0x185c84b08 __CFRunLoopDoSource0
        22  0x185c847f4 __CFRunLoopDoSources0
        23  0x185c83168 __CFRunLoopRun
        24  0x185c82694 CFRunLoopRunSpecific
        25  0x186b5be10 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
        26  0x186bebf50 -[NSRunLoop(NSRunLoop) run]
        27  0x185916900 _xpc_objc_main
        28  0x185916204 xpc_main
        29  0x129909c2c WebKit::XPCServiceMain(int, char const**)
        30  0x12b5a5044 WKXPCServiceMain
        31  0x100113eb0 main
        VM 0x13f412000 on pid 70178 received NeedDebuggerBreak trap

https://build.webkit.org/#/builders/376/builds/620/steps/17/logs/stdio

[Ryan Haddad]

I think this started with https://trac.webkit.org/changeset/287374/webkit

[Radar WebKit Bug Importer]

<rdar://problem/87110829>

[Ryan Haddad]

I think this is also causing the layout test crashes seen here: https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/r287580%20(893)/results.html, but for some reason crashlogs aren't getting generated (or picked up?) by the test runner

[Ryan Haddad]

Reverted in r287595: <https://commits.webkit.org/r287595>