Bug 234857

Summary: REGRESSION (r287382): libANGLE is built into a wrong location on iOS
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, eric.carlson, ews-watchlist, kbr, kondapallykalyan, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+, ews-feeder: commit-queue-

Michael Saboff
Reported 2022-01-04 12:55:36 PST
r287382 made libANGLE go into /System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks on iOS, which is obviously wrong (there is no Versions/A on iOS).
Attachments
Patch (5.86 KB, patch)
2022-01-04 15:54 PST, Michael Saboff 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2022-01-04 12:55:56 PST
<rdar://87072368>
Michael Saboff
Comment 2 2022-01-04 13:30:56 PST
libwebrtc isn't installed in the wrong place, but libwebrtc.xcconfig has some similar bad logic in it.
Michael Saboff
Comment 3 2022-01-04 15:54:04 PST
Created attachment 448342 [details] Patch
EWS Watchlist
Comment 4 2022-01-04 15:55:10 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Michael Saboff
Comment 5 2022-01-05 11:35:07 PST
The mac-debug-wk1 test that EWS flagged, imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-capitalize-007.html, has a flakey history and the patch changes were build product location related.
Michael Saboff
Comment 6 2022-01-05 11:42:51 PST
Committed r287642 (245746@trunk): <https://commits.webkit.org/245746@trunk>
Note You need to log in before you can comment on or make changes to this bug.