Bug 234771

Summary: [LFC][IFC] Incorrect word-spacing gaps between RTL runs
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2021-12-31 14:11:35 PST
ssia
Comment 1 zalan 2021-12-31 14:25:52 PST
Created attachment 448134 [details]
Patch
Comment 2 Antti Koivisto 2022-01-01 01:37:56 PST
Comment on attachment 448134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448134&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h:81
> -    bool isText() const { return m_type == Type::Text; }
> +    bool isText() const { return m_type == Type::Text || isWordSeparator(); }
> +    bool isWordSeparator() const { return m_type == Type::WordSeparator; }

Why do we need display boxes for these? What should we do with them during painting/hit testing?
Comment 3 Antti Koivisto 2022-01-01 01:38:55 PST
Oh I see, isText() still return true so they get treated as text boxes.
Comment 4 EWS 2022-01-01 06:56:50 PST
Committed r287500 (245635@main): <https://commits.webkit.org/245635@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448134 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-01 06:57:23 PST
<rdar://problem/87040223>