Bug 234763

Summary:

css/css-writing-modes/direction-propagation-body-contain-root.html asserts

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, rbuis, simon.fraser, svillar, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tim Nguyen (:ntim) 2021-12-31 02:51:47 PST

ASSERTION FAILED: m_hasValidTop && (m_hasPrecomputedMarginBefore || m_hasValidVerticalMargin)
/Volumes/Data/Code/Safari/OpenSource/Source/WebCore/layout/layouttree/LayoutBoxGeometry.h(198) : WebCore::LayoutUnit WebCore::Layout::BoxGeometry::logicalTop() const
1   0x1324e34a4 WTFCrash
2   0x1463e2204 WTFCrashWithInfo(int, char const*, char const*, int)
3   0x148af698c WebCore::Layout::BoxGeometry::logicalTop() const
4   0x148af6548 WebCore::Layout::BoxGeometry::borderBoxRect(WebCore::Layout::BoxGeometry const&)
5   0x1496aaac4 WebCore::LayoutIntegration::LineLayout::enclosingBorderBoxRectFor(WebCore::RenderInline const&) const
6   0x14a4b24a0 WebCore::RenderInline::linesBoundingBox() const
7   0x14a5f2f0c WebCore::RenderTreeAsText::writeRenderObject(WTF::TextStream&, WebCore::RenderObject const&, WTF::OptionSet<WebCore::RenderAsTextFlag>)
8   0x14a5f5a18 WebCore::write(WTF::TextStream&, WebCore::RenderObject const&, WTF::OptionSet<WebCore::RenderAsTextFlag>)
9   0x14a5f5b9c WebCore::write(WTF::TextStream&, WebCore::RenderObject const&, WTF::OptionSet<WebCore::RenderAsTextFlag>)
10  0x14a5fc1ec WebCore::writeLayerRenderers(WTF::TextStream&, WebCore::RenderLayer const&, WebCore::LayerPaintPhase, WTF::OptionSet<WebCore::RenderAsTextFlag>)
11  0x14a5f6b00 WebCore::writeLayers(WTF::TextStream&, WebCore::RenderLayer const&, WebCore::RenderLayer&, WebCore::LayoutRect const&, WTF::OptionSet<WebCore::RenderAsTextFlag>)
12  0x14a5f6d48 WebCore::writeLayers(WTF::TextStream&, WebCore::RenderLayer const&, WebCore::RenderLayer&, WebCore::LayoutRect const&, WTF::OptionSet<WebCore::RenderAsTextFlag>)
13  0x14a5f70ec WebCore::externalRepresentation(WebCore::RenderBox&, WTF::OptionSet<WebCore::RenderAsTextFlag>)
14  0x14a5f6f30 WebCore::externalRepresentation(WebCore::Frame*, WTF::OptionSet<WebCore::RenderAsTextFlag>)
15  0x118a20234 WebKit::WebPage::renderTreeExternalRepresentation(unsigned int) const
16  0x118574ec8 WKBundlePageCopyRenderTreeExternalRepresentation
17  0x1084bc16c WTR::InjectedBundlePage::dump()
18  0x1084c0aac WTR::dumpAfterWaitAttributeIsRemoved(OpaqueWKBundlePage const*)
19  0x1084bb764 WTR::InjectedBundlePage::frameDidChangeLocation(OpaqueWKBundleFrame const*)
20  0x1084ba040 WTR::InjectedBundlePage::didFinishLoadForFrame(OpaqueWKBundleFrame const*)
21  0x1084b8a88 WTR::InjectedBundlePage::didFinishLoadForFrame(OpaqueWKBundlePage const*, OpaqueWKBundleFrame const*, void const**, void const*)
22  0x118564de0 WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame(WebKit::WebPage&, WebKit::WebFrame&, WTF::RefPtr<API::Object, WTF::RawPtrTraits<API::Object>, WTF::DefaultRefDerefTraits<API::Object> >&)
23  0x118739084 WebKit::WebFrameLoaderClient::dispatchDidFinishLoad()
24  0x14978fff0 WebCore::FrameLoader::checkLoadCompleteForThisFrame()
25  0x149782aec WebCore::FrameLoader::checkLoadComplete()
26  0x149702cdc WebCore::DocumentLoader::finishedLoading()
27  0x1497027e0 WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource&, WebCore::NetworkLoadMetrics const&)
28  0x1498a5164 WebCore::CachedResource::checkNotify(WebCore::NetworkLoadMetrics const&)
29  0x149898850 WebCore::CachedResource::finishLoading(WebCore::FragmentedSharedBuffer const*, WebCore::NetworkLoadMetrics const&)
30  0x1498a26c8 WebCore::CachedRawResource::finishLoading(WebCore::FragmentedSharedBuffer const*, WebCore::NetworkLoadMetrics const&)
31  0x149821eac WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&)
com.apple.WebKit.WebContent.Development terminated (pid 67866) because the process crashed
LEAK: 1 WebPageProxy

Comment 1 Radar WebKit Bug Importer 2022-01-07 02:52:23 PST

<rdar://problem/87243336>

Comment 2 zalan 2022-02-10 12:44:49 PST

Created attachment 451589 [details]
Patch

Comment 3 EWS 2022-02-11 13:40:47 PST

Committed r289667 (247155@main): <https://commits.webkit.org/247155@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451589 [details].