Bug 23476

Summary: HTTP redirect should make application cache updating fail
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch andersca: review+

Description Alexey Proskuryakov 2009-01-22 08:57:28 PST
4. <404/410 handing for manifests>
5. Otherwise, if fetching the manifest fails in some other way (e.g. the server returns another 4xx or 5xx response or equivalent, or there is a DNS error, or the connection times out, or the user cancels the download, or the parser for manifests fails when checking the magic signature), or if the server returned a redirect, or if the resource is labeled with a MIME type other than text/cache-manifest, then run the cache failure steps.
...
16.4 If the previous step fails (e.g. the server returns a 4xx or 5xx response or equivalent, or there is a DNS error, or the connection times out, or the user cancels the download), or if the server returned a redirect, then run the first appropriate step from the following list:

  * If the URL being processed was flagged as an "explicit entry" or a "fallback entry"
       Run the cache failure steps.
Comment 1 Alexey Proskuryakov 2009-01-22 10:01:39 PST
I have a patch ready, but cannot upload it due to a Bugzilla internal error yet.
Comment 2 Alexey Proskuryakov 2009-01-22 11:06:23 PST
Created attachment 26934 [details]
proposed patch
Comment 3 Anders Carlsson 2009-01-28 10:42:49 PST
Comment on attachment 26934 [details]
proposed patch

r=me
Comment 4 Alexey Proskuryakov 2009-01-29 00:36:41 PST
Committed revision 40356.