Summary: | [CSS Color 4] CSS color() function should not clamp channels to the 0-1 range | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | CSS | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clopez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 234741 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Sam Weinig
2021-12-26 15:45:46 PST
Created attachment 448744 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 448751 [details]
Patch
We have a bunch of test duplication with the WPT tests, but I will fix that in another change. Comment on attachment 448751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448751&action=review > Source/WebCore/ChangeLog:8 > + Allow components outside the the 0-1 range for RGB color function types (e.g. color(srgb -2 15 100)). Is this only for code paths that already store the components as floating point values? Does this affect performance in any cases that before would round down to [0,255] integers? (In reply to Darin Adler from comment #6) > Comment on attachment 448751 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448751&action=review > > > Source/WebCore/ChangeLog:8 > > + Allow components outside the the 0-1 range for RGB color function types (e.g. color(srgb -2 15 100)). > > Is this only for code paths that already store the components as floating > point values? Does this affect performance in any cases that before would > round down to [0,255] integers? It's only for the code paths that we already store as float, no change to cases that before would round down to [0,255] integers. Committed r287838 (245890@main): <https://commits.webkit.org/245890@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448751 [details]. |