Bug 234675

Summary: Web Inspector: `shape-outside` description doesn't make sense
Product: WebKit Reporter: Tim Horton <thorton>
Component: Web InspectorAssignee: Razvan Caliman <rcaliman>
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, pangle, rcaliman, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
[fast-cq] Patch 1.0
[fast-cq] Patch 1.0 none

Description Tim Horton 2021-12-24 15:27:53 PST
CSSDocumentation.js says:

    "shape-outside": {
        "description": "Specifies an orthogonal rotation to be applied to an image before it is laid out.",
        "syntax": "none | [ <shape-box> || <basic-shape> ] | <image>",
        "url": "https://developer.mozilla.org/docs/Web/CSS/shape-outside"

I don't think that's a valid description of shape-outside?
Comment 1 Radar WebKit Bug Importer 2021-12-31 15:28:18 PST
Comment 2 Razvan Caliman 2022-01-05 10:34:38 PST
Created attachment 448402 [details]
[fast-cq] Patch 1.0

Add the ability to overwrite individual CSS property documentation fields with data from local JSON file.
Comment 3 Devin Rousso 2022-01-05 12:27:30 PST
Comment on attachment 448402 [details]
[fast-cq] Patch 1.0

r=me, nice solution :)
Comment 4 Simon Fraser (smfr) 2022-01-05 15:25:52 PST
Are we going to get the VSCode description fixed?
Comment 5 Simon Fraser (smfr) 2022-01-05 15:27:02 PST
Seems like we should file an issue at https://github.com/microsoft/vscode-custom-data/issues
Comment 6 EWS 2022-01-06 05:13:21 PST
/Volumes/Data/worker/Commit-Queue/build/Source/WebInspectorUI/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 Razvan Caliman 2022-01-06 05:38:29 PST
Created attachment 448490 [details]
[fast-cq] Patch 1.0

Carry over R+; fix missing reviewer from Changelog
Comment 8 EWS 2022-01-06 05:42:13 PST
Committed r287682 (245778@main): <https://commits.webkit.org/245778@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448490 [details].