| Summary: | Web Inspector: blackboxed call frames should be grouped everywhere | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 234581 | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2021-12-23 13:46:56 PST
Created attachment 449279 [details]
Patch
Comment on attachment 449279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review r=me > Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163 > + firstNonNativeNonAnonymousCallFrame ??= frame; Nice catch. It's a bit concerning that we don't seem to test this anywhere, though. Comment on attachment 449279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review >> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163 >> + firstNonNativeNonAnonymousCallFrame ??= frame; > > Nice catch. It's a bit concerning that we don't seem to test this anywhere, though. Good point! I'll add a test for this :) And actually, I'll split this into a separate bug. Created attachment 449505 [details]
Patch
Committed r288243 (246196@main): <https://commits.webkit.org/246196@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449505 [details]. |