Bug 234644

Summary:	merge-queue is marking builds as FAILURE when it successfully lands PR after retry
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, ap, jean-yves.avenard, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=222038

Description Aakash Jain 2021-12-23 12:42:34 PST

Currently if the commit-queue build fails initially and on retry it succeeds, then buildbot build is marked as FAILURE, and the commit-queue status-bubble is RED. e.g.: https://ews-build.webkit.org/#/builders/28/builds/17399

Commit-queue should mark the build as SUCCESS and commit-queue status bubble should be green.

Comment 1 Radar WebKit Bug Importer 2021-12-30 12:43:17 PST

<rdar://problem/87017360>

Comment 2 Aakash Jain 2023-08-11 14:19:36 PDT

This problem happens with commit-queue, merge-queue and unsafe-merge-queue. Also, it seems to happen frequently. 

e.g.: 
https://ews-build.webkit.org/#/builders/19/builds/3586
https://ews-build.webkit.org/#/builders/19/builds/3584
https://ews-build.webkit.org/#/builders/19/builds/3583

https://ews-build.webkit.org/#/builders/22/builds/1723
https://ews-build.webkit.org/#/builders/22/builds/1716
https://ews-build.webkit.org/#/builders/22/builds/1701
https://ews-build.webkit.org/#/builders/22/builds/1699
https://ews-build.webkit.org/#/builders/22/builds/1690
https://ews-build.webkit.org/#/builders/22/builds/1619
https://ews-build.webkit.org/#/builders/22/builds/1618
https://ews-build.webkit.org/#/builders/22/builds/1612
https://ews-build.webkit.org/#/builders/22/builds/1611
https://ews-build.webkit.org/#/builders/22/builds/1607
https://ews-build.webkit.org/#/builders/22/builds/1605
https://ews-build.webkit.org/#/builders/22/builds/1603
https://ews-build.webkit.org/#/builders/22/builds/1601

Comment 3 Aakash Jain 2023-08-14 14:58:14 PDT

Pull request: https://github.com/WebKit/WebKit/pull/16682

Comment 4 EWS 2023-08-14 15:15:12 PDT

Committed 266880@main (afae26e95040): <https://commits.webkit.org/266880@main>

Reviewed commits have been landed. Closing PR #16682 and removing active labels.

Comment 5 Aakash Jain 2023-08-15 03:07:38 PDT

Restarted ews to pick up this change.