Bug 234636

Summary: [:has() pseudo-class] Support :disabled and :enabled pseudo-class invalidation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, ntim, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/32182
Bug Depends on:    
Bug Blocks: 234556    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antti Koivisto
Reported 2021-12-23 04:21:29 PST
:has(:disabled)
Attachments
Patch (10.49 KB, patch)
2021-12-23 04:30 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (11.47 KB, patch)
2021-12-23 04:32 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (14.02 KB, patch)
2021-12-26 07:56 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-12-23 04:30:46 PST
Created attachment 447871 [details] Patch
Antti Koivisto
Comment 2 2021-12-23 04:31:07 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/32182
Antti Koivisto
Comment 3 2021-12-23 04:32:04 PST
Created attachment 447872 [details] Patch
EWS Watchlist
Comment 4 2021-12-23 04:32:13 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Tim Nguyen (:ntim)
Comment 5 2021-12-23 09:25:29 PST
Comment on attachment 447872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447872&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:164 > + Style::PseudoClassChangeInvalidation disabledInvalidation(*this, CSSSelector::PseudoClassDisabled); Does this need something similar for `:enabled`? Same here and below
Antti Koivisto
Comment 6 2021-12-26 07:45:23 PST
> Does this need something similar for `:enabled`? Yeah, good point. Sad there are no tests that fail yet for that.
Antti Koivisto
Comment 7 2021-12-26 07:56:33 PST
Created attachment 447973 [details] Patch
EWS
Comment 8 2021-12-26 10:46:40 PST
Committed r287445 (245580@main): <https://commits.webkit.org/245580@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447973 [details].
Radar WebKit Bug Importer
Comment 9 2021-12-26 10:47:16 PST
<rdar://problem/86919760>
Tim Nguyen (:ntim)
Comment 10 2023-09-04 21:31:03 PDT
*** Bug 232233 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.