Bug 234587

Summary:

Allow loop tier up to the Air tier

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, justin_michaud, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
WIP	none
WIP	none
WIP	none
patch	ysuzuki: review+, ews-feeder: commit-queue-
patch for landing	none

Saam Barati

Reported 2021-12-21 18:31:23 PST

Probably will be a perf win for first run programs.

Attachments
WIP (97.29 KB, patch) 2022-01-04 11:42 PST, Saam Barati	no flags	Details Formatted Diff Diff
WIP (45.74 KB, patch) 2022-01-04 17:53 PST, Saam Barati	no flags	Details Formatted Diff Diff
WIP (44.40 KB, patch) 2022-01-07 18:38 PST, Saam Barati	no flags	Details Formatted Diff Diff
WIP (44.69 KB, patch) 2022-01-07 19:04 PST, Saam Barati	no flags	Details Formatted Diff Diff
patch (47.38 KB, patch) 2022-01-07 19:24 PST, Saam Barati	ysuzuki: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
patch for landing (47.38 KB, patch) 2022-01-10 10:00 PST, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2021-12-21 18:31:43 PST

If we add a new lightweight Baseline JIT, this probably isn't necessary.

Radar WebKit Bug Importer

Comment 2 2021-12-28 18:32:16 PST

<rdar://problem/86968638>

Saam Barati

Comment 3 2022-01-04 11:42:11 PST

Created attachment 448313 [details] WIP

Saam Barati

Comment 4 2022-01-04 17:53:58 PST

Created attachment 448356 [details] WIP Fixed latent regalloc bug in O0. I think this patch is mostly ready. But I'm going to implement exceptions in Air first, since that'll make some of the tier up logic nicer, and it's a nice to have anyways, since we want all tiers supporting all wasm features.

Saam Barati

Comment 5 2022-01-07 18:38:58 PST

Created attachment 448657 [details] WIP

Saam Barati

Comment 6 2022-01-07 19:04:26 PST

Created attachment 448661 [details] WIP

Saam Barati

Comment 7 2022-01-07 19:24:35 PST

Created attachment 448662 [details] patch

Yusuke Suzuki

Comment 8 2022-01-07 19:43:31 PST

Comment on attachment 448662 [details] patch r=me