Summary: | LLInt should loop OSR into BBQ and BBQ should loop OSR into OMG | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Saam Barati
2021-12-20 18:16:34 PST
Created attachment 447772 [details]
patch
Created attachment 447815 [details]
patch
Created attachment 447823 [details]
patch
Comment on attachment 447823 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=447823&action=review > Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:76 > + //CompilationMode targetCompilationMode = m_callee->compilationMode() == CompilationMode::LLIntMode ? CompilationMode::BBQForOSREntryMode : CompilationMode::OMGForOSREntryMode; > + CompilationMode targetCompilationMode = CompilationMode::OMGForOSREntryMode; Is this comment-out intentional? It looks like we are always compiling it via OMG, which is not aligned to the bug's title. Created attachment 447830 [details]
patch
Comment on attachment 447830 [details]
patch
r=me
Committed r287379 (245519@main): <https://commits.webkit.org/245519@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447830 [details]. |